Repository navigation
Fixes problem with symbols as single expression inside if clause - #300
Open
averissimo wants to merge 3 commits into
Open
averissimo wants to merge 3 commits into
averissimo wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused guard resolves the reported failure and is covered by a representative regression test.
1 open finding
What changed in this PR
Fixes symbol-only expressions inside if blocks so qenv dependency extraction no longer errors.
Changes:
- Guards symbol expressions before AST subsetting.
- Adds regression coverage for issue #299.
- Documents the bug fix.
| File | Description |
|---|---|
R/utils-get_code_dependency.R |
Safely handles symbol expressions. |
tests/testthat/test-qenv_within.R |
Adds regression coverage. |
NEWS.md |
Records the fix. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Unit Tests Summary 1 files 14 suites 4s ⏱️ Results for commit abe40cf. ♻️ This comment has been updated with latest results. |
Contributor
Unit Test Performance Difference
Additional test case details
Results for commit feca7c4 ♻️ This comment has been updated with latest results. |
Contributor
Code Coverage SummaryDiff against mainResults for commit: abe40cf Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pull Request