-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature evensub #58
Open
AntanasGa
wants to merge
13
commits into
instafluff:master
Choose a base branch
from
AntanasGa:feature-evensub
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature evensub #58
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
0994c50
npm install
AntanasGa a1ff357
seperating client id fetching
AntanasGa 4c4b428
hooking up channel and event subscription
AntanasGa 9fa342c
adding type definitions
AntanasGa a61ef30
moving `requiredScopes` to parameters
AntanasGa 5ca9e7d
exposing disconnect in `eventSubConnectAsync`
AntanasGa 58e386f
correcting base connection
AntanasGa 32db69a
adding event dispatch invoking function
AntanasGa 93db2fe
adding eventsub initialization
AntanasGa 31db7bf
reverting `package-lock.json`
AntanasGa 7fa5e19
correcting keep alive declaration
AntanasGa 1cf5256
adding unique message detection
AntanasGa 79e208e
correcting permission check
AntanasGa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be good to be able to have this websocket available outside of the function or to return it after the connect completes to be able to call it and disconnect or do other things with it. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we planning on using it outside point rewards?
https://dev.twitch.tv/docs/eventsub/handling-websocket-events/#revocation-message
I'm not sure if that applies to first subscription or the entire lifecycle
i think it would be reasonable to return the obscured
onDisconnect
function