Add SDG library code #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You'll need to move the test script to a different directory. It's getting picked up by the automation that runs unit tests. If you move it, it shouldn't run. |
russellb
reviewed
Jun 25, 2024
RobotSail
reviewed
Jun 25, 2024
RobotSail
reviewed
Jun 25, 2024
RobotSail
approved these changes
Jun 25, 2024
russellb
force-pushed
the
redesign-dev
branch
2 times, most recently
from
304ff47 to
7b27b9c
Compare
aakankshaduggal
force-pushed
the
redesign-dev
branch
4 times, most recently
from
ec0cb76 to
6bf7e14
Compare
Signed-off-by: Aakanksha Duggal <[email protected]> Co-authored-by: Oindrilla Chatterjee <[email protected]> Co-authored-by: Shiv <[email protected]>
Signed-off-by: Russell Bryant <[email protected]> Move test_knowledge.py out of unit tests dir Move this script so it's not run in unit test automation. Signed-off-by: Russell Bryant <[email protected]> Ensure configs get included in Python package We need to have `__init__.py` in this directory for it to get picked up and included in the Python package so the files are present after it gets installed. Signed-off-by: Russell Bryant <[email protected]> Add SPDX-License-Identifier headers to new source files Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: shiv <[email protected]> Co-authored-by: Oindrilla Chatterjee <[email protected]> :recycle: refactoring sdg class Signed-off-by: shiv <[email protected]> :sparkles: adding freeform skills gen capability Signed-off-by: shiv <[email protected]> added iterative wrapper block Signed-off-by: Oindrilla Chatterjee <[email protected]> added iterative wrapper block Signed-off-by: Oindrilla Chatterjee <[email protected]>
The previous code assumed using the library in a script running out of the source tree as the current working directory. This change makes the code expect to find these files wherever the python library is located. This is necessary for loading these files from an installed version of this package. Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: Aakanksha Duggal <[email protected]>
Signed-off-by: Russell Bryant <[email protected]> Ignore new sdg lib files in mypy checks Signed-off-by: Russell Bryant <[email protected]> Remove unused python imports Signed-off-by: Russell Bryant <[email protected]> Remove duplicate definition of SynthGroundedSkillsFlow Signed-off-by: Russell Bryant <[email protected]> Add missing calls to parent class init methods Signed-off-by: Russell Bryant <[email protected]> Ignore the last couple of lint warnings Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: Aakanksha Duggal <[email protected]>
aakankshaduggal
force-pushed
the
redesign-dev
branch
from
6bf7e14 to
0010655
Compare
|
As of right now, none of this new code is being used, so it will not break the CLI (as confirmed by the e2e CI job). Since this is so big, we're going to merge and keep working on it in tree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the code for the SDG library #41
In order to test the code, you can run the
tests/test_knowledge.py, specify the model endpoint and run the file from the root like such -python3 -m tests.test_knowledge.pyCorresponding design doc: https://github.com/instructlab/dev-docs/blob/main/docs/sdg/sdg-api-interface.md