Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib to knowledge sports cricket section #1232

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions knowledge/software/products/Maximo/attribution.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Title of work: Maximo application Authorization
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title and this is different.

Link to work: https://www.ibm.com/docs/en/mas-cd/maximo-manage/continuous-delivery?topic=groups-application-templates
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can not accept things that aren't in our approved list for the upstream model.

License of the work: ABCD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be the correct wording.

Creator names: IBM Documentation
31 changes: 31 additions & 0 deletions knowledge/software/products/Maximo/qna.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
version: 1

Check failure on line 1 in knowledge/software/products/Maximo/qna.yaml

View workflow job for this annotation

GitHub Actions / yamllint

1:1 [.version] 2 was expected
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to version: 2

task_description: 'Correct the model for a authorisation access to the Maximo product'
created_by: vainakil
domain: maximo_world
seed_examples:
- question: What is a security template in Maximo ?
answer: |
It is a predefined set of permissions given to objects.
- question: How does security template work ?
answer: |
A security template has predefined permission to objects , requires for a application to work correctly.
- question: How do I give myself access to a application using a security template in Maximo ?
answer: |
You can apply a security template through Security Groups application.
- question: How can we use a security template in Maximo?
answer: |
You can apply a security template to a application using Security Groups application in Maximo.

Check failure on line 17 in knowledge/software/products/Maximo/qna.yaml

View workflow job for this annotation

GitHub Actions / yamllint

17:103 trailing spaces (trailing-spaces)
- question: Why to use a security template in Maximo.
answer: |
To give access to a application so it will work correctly.
- question: I can't see the application menu, how can a security template fix it ?.
answer: |
A security template will give you required permissions to access the application.
- question: When should the security template be used in Maximo ?
answer: |
When you need to give permissions to the application you are accessing.
document:
repo: https://github.com/nvaibhav/maximo
commit: aa9b2fb
patterns:
- data.md
4 changes: 4 additions & 0 deletions knowledge/sports/cricket/worldcups/attribution.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Title of work: 1987 Cricket World Cup
Link to work: https://en.wikipedia.org/wiki/Cricket_World_Cup
License of the work: WP:CC BY-SA
Creator names: Wikipedia Authors
16 changes: 16 additions & 0 deletions knowledge/sports/cricket/worldcups/qna.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
version: 1

Check failure on line 1 in knowledge/sports/cricket/worldcups/qna.yaml

View workflow job for this annotation

GitHub Actions / yamllint

1:1 [.version] 2 was expected
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to the version: 2

task_description: 'Correct the model for 1987 world cup'
created_by: vainakil
domain: cricket_world
seed_examples:
- question: Who won the cricket 1987 world cup ?

Check failure on line 6 in knowledge/sports/cricket/worldcups/qna.yaml

View workflow job for this annotation

GitHub Actions / yamllint

6:1 [.seed_examples] Value must have at least 5 items
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There needs to be at least 5 questions.

answer: |
Australia won the championship by defeating England by 7 runs in the final
- question: Did India win the 1987 cricket world cup ?

Check failure on line 9 in knowledge/sports/cricket/worldcups/qna.yaml

View workflow job for this annotation

GitHub Actions / yamllint

9:56 trailing spaces (trailing-spaces)
answer: |
India hosted the world cup however didn't win it. Australia won it.
document:
repo: https://github.com/nvaibhav/cricket

Check warning on line 13 in knowledge/sports/cricket/worldcups/qna.yaml

View workflow job for this annotation

GitHub Actions / yamllint

13:3 wrong indentation: expected 1 but found 2 (indentation)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also is not the complete file, this needs to be the complete file from wikipedia to be considered to be upstreamed.

commit: 199f994
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be the complete SHA.

patterns:
- data.md

Check warning on line 16 in knowledge/sports/cricket/worldcups/qna.yaml

View workflow job for this annotation

GitHub Actions / yamllint

16:5 wrong indentation: expected 3 but found 4 (indentation)
Loading