Add one more AT_DISPATCH for layer norm gamma scalar type #883
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original kernel only do AT_DISPATCH on input dtype, while weight/bias (gamma/beta) may have different data types. It will break when trying to get
gamma.data_ptr<weight_t>()
, for its wrong scalar type.Same issue break comfirmed on cuda.
Fixing this by adding one more AT_DISPATCH.