Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented the builder method and integrated it with the service objects #40

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Implemented the builder method and integrated it with the service objects #40

merged 1 commit into from
Jul 21, 2022

Conversation

fear-the-reaper
Copy link
Contributor

@fear-the-reaper fear-the-reaper commented Jul 21, 2022 •
edited
Loading

Description

Implemented the builder method and integrated it with the service objects, added comments in the `connector.go`, and removed the `Display` method in `tag.go`

Issues

#27

Type of change

list down the type of change

  • Bug fix
  • New feature (added a new endpoint or created)
  • Breaking fix (a bug fix or new feature that would cause exisiting functionality not to work as expected)

Checklist

  • if a new feature was added it passed all its (if made) test cases
  • if a bug fix was added it passed all its existing test cases

Important Rules

  • If your changes decrease the overall tests coverage (you will know after the Codecov CI job is done), you should add the required tests to fix the problem
  • Everytime you make changes to the PR and you think the work is done, you should explicitly ask for a review

Please delete if the PR is for bug fixing.

@fear-the-reaper
Implemented the builder pattern method and integrated it with the ser…
c748542 
…vice objects, as well as included comments in connector.go, and remove the Display method from tag.go
@fear-the-reaper fear-the-reaper requested review from sp35 and eshaan7 July 21, 2022 06:40
@fear-the-reaper fear-the-reaper added the GSoC Issues that can be worked on before/during GSoC-2022 label Jul 21, 2022
@sp35 sp35 merged commit 1dffbc5 into main Jul 21, 2022
@sp35 sp35 deleted the request_builder_pattern branch July 21, 2022 19:03
@fear-the-reaper fear-the-reaper mentioned this pull request Sep 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sp35 sp35 sp35 approved these changes

@eshaan7 eshaan7 Awaiting requested review from eshaan7

Assignees
No one assigned
Labels
GSoC Issues that can be worked on before/during GSoC-2022
Projects
GSoC'22 - go-intelowl
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fear-the-reaper @sp35