Pages flag added for listing jobs based on page number #265
+30
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pranjalg1331 <[email protected]>
|
@fgibertoni Please review. |
fgibertoni
requested changes
Jan 10, 2025
| @@ -581,6 +581,24 @@ def get_all_jobs(self) -> List[Dict[str, Any]]: | |||
| response = self.__make_request("GET", url=url) | |||
| return response.json() | |||
|
|
|||
| def get_jobs_by_page(self, page: int) -> List[Dict[str, Any]]: | |||
There was a problem hiding this comment.
Just to align the parameter to the others.
Suggested change
| def get_jobs_by_page(self, page: int) -> List[Dict[str, Any]]: | |
| def get_jobs_by_page(self, page: Union[int, str]) -> List[Dict[str, Any]]: |
| @@ -42,12 +42,22 @@ def jobs(): | |||
| show_choices=True, | |||
| help="Only show jobs having a particular status", | |||
| ) | |||
| @click.option( | |||
| "-p", | |||
| "--page", | |||
There was a problem hiding this comment.
I think this parameter should be added so that the --help option of the ls command shows that it's expecting an interger and not text.
Suggested change
| "--page", | |
| "--page", | |
| type=int, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have added a new function
get_jobs_by_pagethat returns a jobs list based on the page number.Please include a summary of the change.
Related issues
Closes #264
Type of change
Please delete options that are not relevant.
Checklist
Blackgave 0 errors.Flakegave 0 errors.please follow these rules
Real World Example
Please delete if the PR is for bug fixing.
Otherwise, please provide the resulting raw JSON of a finished analysis (and, if you like, a screenshot of the results). This is to allow the maintainers to understand how the analyzer works.