feat: implement map to retain original struct field names in schema #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Introduces a mapping mechanism within the `Schema` type to store the original reflected struct field names before any modifications.
karimkhaleel
force-pushed
the
original-names-mapping
branch
from
5eb3a54 to
00bb22f
Compare
|
Added a test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request introduces a new enhancement that addresses the feature request outlined in #116. A public map[string]string has been added to the Schema struct which serves to preserve the original names of struct fields as reflected before any modifications by struct tags or
KeyNamer.The primary purpose of this new field is to provide an accessible means through the schema object, enabling the matching of an instantiated struct's fields with the corresponding schema definitions during a post-processing phase.
Usage Example:
An envisioned application of this feature, pending its acceptance and merge, can be previewed in the lazygit project's open pull request, specifically at generate.go#L43.
With this addition, developers can now directly utilize the unaltered struct field names from the schema object, simplifying and streamlining the schema manipulation process.