Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pls update icontwo to 0.98.0 #3020

Merged
merged 1 commit into from
Dec 3, 2023
Merged

pls update icontwo to 0.98.0 #3020

merged 1 commit into from
Dec 3, 2023

Conversation

skvarel
Copy link
Contributor

@skvarel skvarel commented Dec 1, 2023

No description provided.

@github-actions github-actions bot added Stable auto-checked This PR was automatically checked for obvious criterias labels Dec 1, 2023
Copy link

github-actions bot commented Dec 1, 2023

Automated adapter checker

ioBroker.vis-icontwo

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

👍 No errors found

  • 👀 [W171] "common.title" is deprecated in io-package.json
  • 👀 [W105] "common.titleLang" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W109] "common.desc" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W170] "common.keywords" should not contain "iobroker, adapter, smart home" io-package.json
  • 👀 [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
  • 👀 [W172] "common.localLink" in io-package.json is deprecated. Please define object "common.localLinks": { "_default": "..." }
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W513] "gulpfile.js" found in repo! Think about migrating to @iobroker/adapter-dev package

Adapter releases: https://www.iobroker.dev/adapter/vis-icontwo/releases

Adapter statistic: https://www.iobroker.dev/adapter/vis-icontwo/statistics

Add comment "RE-CHECK!" to start check anew

@mcm1957
Copy link
Collaborator

mcm1957 commented Dec 2, 2023

0.98.0 created 26.11.2023
OK

@mcm1957
Copy link
Collaborator

mcm1957 commented Dec 2, 2023

@skvarel

  • Your adapter requests a restart of vis. As vis-2 is available in the meantime two, please extend the rsatrt clause to include vis and vis-2

  • Your adapter defined 'vis* as dependency. This causes problems when used with vis-2. This dependency is not needed at all, as the adapter only prrovides icons and can be installed at any time. Icons canbe used by any software / adapetr and are (most likely) not restricted to work with vis. So please remove vis from dependencies.

I've prepared PR inventwo/ioBroker.vis-icontwo#528. Please check and apply.

NOTE:
As dependencies are updated from grithub NO new release is required. Just update io.package.json please and
please drop a comment here when done.

@mcm1957 mcm1957 added the must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review label Dec 2, 2023
@skvarel
Copy link
Contributor Author

skvarel commented Dec 3, 2023

merge is done

@github-actions github-actions bot added the *📬 a new comment has been added label Dec 3, 2023
@mcm1957 mcm1957 removed the must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review label Dec 3, 2023
@mcm1957 mcm1957 merged commit 88e29b9 into ioBroker:master Dec 3, 2023
10 checks passed
@mcm1957 mcm1957 removed the *📬 a new comment has been added label Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-checked This PR was automatically checked for obvious criterias
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants