Repository navigation
Enable "wait for healthy containers" by default - #3928
Merged
Merged
Conversation
It looks like the 'wait for healthy containers' check works well. Let's make it the default setting and document how to turn it off.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The newly default timeout path gives users an incorrect configuration key in its recovery hint.
Review effort: Balanced
Findings: 1
What changed in this PR
Enables container health checks by default for Containerlab and documents timeout configuration.
Changes:
- Sets a 600-second default health timeout.
- Documents disabling or extending health checks.
- Clarifies SSH timeout configuration scope.
| File | Description |
|---|---|
netsim/providers/clab.yml |
Enables health checks by default. |
docs/labs/clab.md |
Documents health and SSH readiness behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| sr: [ mpls-router, mpls-iptunnel ] | ||
| vxlan: [ vxlan, udp_tunnel, ip6_udp_tunnel ] | ||
| vrf: [ vrf ] | ||
| healthy_timeout: 600 # Reasonably large default "wait for containers to become healthy" timeout |
sdargoeuves
reviewed
Oct 7, 2026
sdargoeuves
left a comment
sdargoeuves
left a comment
Collaborator
There was a problem hiding this comment.
That's great, and indeed 600 should be a pretty good default.
unless you have ~50 vrnetlab containers, in which case you may want to increase that timeout!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like the 'wait for healthy containers' check works well. Let's make it the default setting and document how to turn it off.