Repository navigation
Move netmiko parameters to device features - #3930
Merged
Merged
Conversation
Netmiko parameters were stored in group variables, but it's probably cleaner to have them in device features. This PR moves netmiko_* group variables into netmiko.* features and adds netmiko-specific debugging.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Netmiko debug output currently exposes authentication credentials in plaintext.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Moves Netmiko driver settings from group variables into device features and adds Netmiko-specific diagnostics.
Changes:
- Defines device types and error patterns under
features.netmiko. - Updates deployment code to consume the new feature structure.
- Adds
netmikodebug output and integration-test configuration.
| File | Description |
|---|---|
tests/platform-integration/config/06-netmiko.yml |
Migrates the integration test to Netmiko features. |
netsim/utils/netmiko.py |
Reads connection parameters from device features and adds debugging. |
netsim/providers/libvirt/configs.py |
Logs script output during Netmiko debugging. |
netsim/devices/linux.yml |
Adds the Linux Netmiko device type feature. |
netsim/devices/ios.yml |
Migrates IOS Netmiko settings. |
netsim/devices/frr.yml |
Adds the FRR/Linux Netmiko device type. |
netsim/devices/eos.yml |
Migrates EOS Netmiko settings. |
netsim/cli/initial/utils.py |
Accepts the Netmiko debug category. |
netsim/cli/initial/netmiko.py |
Uses feature-based error patterns and logs configuration results. |
netsim/cli/__init__.py |
Adds Netmiko to global debug choices. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Netmiko parameters were stored in group variables, but it's probably cleaner to have them in device features.
This PR moves netmiko_* group variables into netmiko.* features and adds netmiko-specific debugging.