Repository navigation
Add 'step_config' netmiko feature - #3932
Merged
Merged
Conversation
Netmiko does not exit the config mode after send_config_from_file on some devices (IOS XR). An explicit 'exit from config mode' is needed on those devices. Also: add 'commit' and 'exit_config_mode' results to debugging printout
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Stock IOS XR definitions do not enable the new flag, so the reported issue remains unresolved.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Adds optional Netmiko config-mode exit handling and includes commit/exit responses in debug output.
Changes:
- Adds the
netmiko.step_configfeature gate. - Appends commit and exit-config responses to results.
| File | Description |
|---|---|
netsim/cli/initial/netmiko.py |
Implements gated config-mode exit and expanded debugging output. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Netmiko does not exit the config mode after send_config_from_file on some devices (IOS XR). An explicit 'exit from config mode' is needed on those devices.
Also: add 'commit' and 'exit_config_mode' results to debugging printout