Feature/fade on top scale num columns #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for the topmost items to fade out when scrolling
Allows for setting the minimum scale for the scale out animation
By passing numColumns to the <VegaScrollList/> component the FlatList layout will reflect the chosen cols and the VegaScrollItems will animate for all top cols
Reason for pull request:I noticed that when more columns was added using numColumns, the actual columns were never taken into account for the animations. Only the first item would animate, then scrolling further down. Things got messy. As such, I propose these minimal changes to allow for animating flatlists with more than one column. Also additionally, there was a lack of configuration capabilities, so alongside numColumns feature, I've also added 2 more parameters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added flatlist numColumns functionality to VegaScrollList + config parameters