Skip to content

Add normalized OrderBy stream methods - #232

Merged
gordonwatts merged 4 commits into
masterfrom
codex-orderby-objectstream
Jul 9, 2026
Merged

gordonwatts merged 4 commits into
masterfrom
codex-orderby-objectstream

Conversation

@gordonwatts

@gordonwatts gordonwatts commented Jul 9, 2026 •

Copy link
Copy Markdown
Member

This just adds the methods, it does not implement them. However, they have to be here before they can be implemented. Once this PR is approved and merged, then the changes can go into the backends.

Summary

  • Add OrderBy and OrderByDescending to ObjectStream with normalized backend-visible AST calls
  • Preserve the key selector lambda in the query AST without performing local sorting
  • Extend extension-function normalization coverage for the new operators

Validation

  • .venv\Scripts\python.exe -m pytest tests/test_object_stream.py tests/ast/test_func_adl_ast_utils.py -q
  • .venv\Scripts\python.exe -m black --check --target-version py313 tests/test_object_stream.py tests/ast/test_func_adl_ast_utils.py func_adl/object_stream.py func_adl/ast/func_adl_ast_utils.py
  • .venv\Scripts\python.exe -m flake8 func_adl tests

Fixes #22

@gordonwatts gordonwatts self-assigned this Jul 9, 2026
@gordonwatts gordonwatts added the enhancement New feature or request label Jul 9, 2026
@codecov-commenter

codecov-commenter commented Jul 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.81%. Comparing base (bc64538) to head (3d0205a).
⚠️ Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
+ Coverage   95.72%   95.81%   +0.08%     
==========================================
  Files          15       15              
  Lines        1662     1672      +10     
==========================================
+ Hits         1591     1602      +11     
+ Misses         71       70       -1     
Flag Coverage Δ
unittests 95.81% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gordonwatts
gordonwatts marked this pull request as ready for review July 9, 2026 08:35
@gordonwatts
gordonwatts requested a review from RogerJanusiak July 9, 2026 08:35
@gordonwatts
gordonwatts merged commit 5772996 into master Jul 9, 2026
20 of 21 checks passed
@gordonwatts
gordonwatts deleted the codex-orderby-objectstream branch July 9, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add sorting to the language

3 participants