Repository navigation
fix: preserve dump entries when loading TTL values - #422
Open
LucasLeao18 wants to merge 1 commit into
Open
LucasLeao18 wants to merge 1 commit into
LucasLeao18 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading a dump converts each entry.start in place from a portable Date.now() timestamp to a performance timestamp. Loading the same dump into another cache then makes its TTL entries stale.
Copy the per-entry options before converting the timestamp. The regression checks input preservation and reuse across two caches.
Fixes #421.
Validation (Node.js 24.15.0, Windows): The new regression fails before the fix and passes afterward. tshy and all six esbuild bundles build successfully. Full tap run: 19,373 assertions pass. Oxlint and Prettier checks pass. On Windows, an uncommitted local preload uses directory junctions for tap plugin setup; @tapjs/clock was installed only in the generated .tap plugin environment. No dependency/config changes are included.
AI assistance: this contribution was prepared with OpenAI Codex; the change and regression results were reviewed before submission.