Repository navigation
Restore bare fn package compatibility - #18
Merged
Merged
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop reserving ASCII
fn; it now follows the ordinarySYMBOLpath again, whileλandƒremain function-constructor spellings.The compatibility smoke:
function(call, fn) { fn <- ... }fixture;λandƒstill construct functions;rlangfrom source under IR and loads it;←,÷,≟) independently of packages whose source intentionally relies on standard-R=assignment.The broader
testthat/tibble/dplyrsmoke from issue #12 is not claimed here. Its transitivevctrsdependency uses bare=assignment in package source, while IR deliberately gives=equality semantics. That is a separate compatibility boundary from thefnlexer regression. The previous CI also exposed an unrelated missinglibuvdevelopment header throughfs.The README states that
fnis an ordinary identifier and thatfn(...)is an ordinary call, not constructor syntax.This is stacked on #5 because the smoke test uses the preferred
≟spelling introduced there. It removes the parser blocker for dilapidated-shed/r-koans#2.Addresses the bare-
fnportion of #12; the broader package-stack question remains open.