Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API cleanup #429

Merged
merged 5 commits into from
Jan 10, 2025
Merged

API cleanup #429

merged 5 commits into from
Jan 10, 2025

Conversation

rimi-itk
Copy link
Contributor

@rimi-itk rimi-itk commented Jan 9, 2025

@rimi-itk rimi-itk force-pushed the feature/3534-api-cleanup branch 10 times, most recently from 37e9631 to b3516cc Compare January 9, 2025 13:11
@rimi-itk rimi-itk requested a review from sinejespersen January 9, 2025 13:16
@rimi-itk rimi-itk marked this pull request as ready for review January 9, 2025 13:16
@rimi-itk rimi-itk force-pushed the feature/3534-api-cleanup branch from b3516cc to 9d51e37 Compare January 9, 2025 13:23
task composer -- install
task coding-standards:twig:check
# Check for any changes (task …:check runs task …:apply)
- run: git diff --exit-code

code-analysis:
name: PHP - Code analysis
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two uses?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@sinejespersen sinejespersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with a question

@rimi-itk rimi-itk merged commit 3e08c4c into develop Jan 10, 2025
15 checks passed
@rimi-itk rimi-itk deleted the feature/3534-api-cleanup branch January 10, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants