Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move py39-scikit-learn dependency to Pip #7

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

zebrapurring
Copy link

@tornadoracer
Copy link
Owner

I went back and forth on packages that should be installed in the jail vs installed after the jail was created with pip. FYI, there are already packages installed in the paperless virtual environment in overlay/tmp/paperless_install. Perhaps should we move it from post_install.sh to overlay/tmp/paperless_install to be consistent? I had to use a virtual environment to get everything to play nicely.

@zebrapurring
Copy link
Author

Yes, there are two issues currently:

  • Services executing celery are not running inside the virtual environment (see 28ee2a9)
  • Some packages are manually removed from requirements.txt:
    sed -i "" -e '/scikit-learn/d;/pikepdf/d;/scipy/d;/numpy/d;s/pyyaml==6.0$/pyyaml==6.0.1/' /opt/paperless/requirements.txt

Both issues are fixed with the upgrade to v2.7.2 in #8, so I didn't want to spend much time fixing and testing the installation for the current version.

@tornadoracer
Copy link
Owner

Makes sense. I'll test and if it works for me, will merge your changes. Thanks!!

@tornadoracer tornadoracer merged commit 2f54e7c into tornadoracer:master Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation of paperless-ngx fails
2 participants