Add safari extension sync, validate, and macOS build - #181
Merged
Merged
Conversation
2 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
==========================================
+ Coverage 75.96% 75.98% +0.01%
==========================================
Files 70 70
Lines 30367 30367
==========================================
+ Hits 23069 23073 +4
+ Misses 7298 7294 -4 🚀 New features to boost your workflow:
|
ja7ad
reviewed
Sep 13, 2026
Owner
There was a problem hiding this comment.
I think better build and upload artifacts happen on new tags pushed, you can add this stage into release.yml workflow.
VedantMadane
force-pushed
the
ci/safari-extension-build
branch
from
September 21, 2026 11:05
83862ea to
fdf1d53
Compare
Owner
|
@VedantMadane Please fix conflicts from main in your branch. |
Add .github/workflows/safari-extension.yml that: - regenerates Safari Resources from Chrome sources and fails if dirty - validates MV3 manifest and required assets on Ubuntu - builds the Safari wrapper app with full Xcode on macos-latest - uploads the built .app as a CI artifact for inspection Fixes ja7ad#1 Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
safari-web-extension-converter creates Xcode projects with a macOS 10.14 deployment target by default. However, SFExtensionMessageKey requires macOS 11.0+ (Big Sur), causing xcodebuild in CI to fail with 'error: SFExtensionMessageKey is only available in macOS 11.0 or newer'. - Add @available(macOS 11.0, *) and runtime availability fallback checks in SafariWebExtensionHandler.swift - Ensure MACOSX_DEPLOYMENT_TARGET is at least 11.0 in project.pbxproj and pass MACOSX_DEPLOYMENT_TARGET=11.0 to xcodebuild in scripts/build-safari-extension.sh Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
safari-web-extension-converter defaults the parent app bundle ID to <prefix>.<app-name> (io.github.ja7ad.hydra.Hydra-Safari-Extension) while the extension uses io.github.ja7ad.hydra.safari.Extension. This triggers Xcode ValidateEmbeddedBinary error: 'Embedded binary's bundle identifier is not prefixed with the parent app's bundle identifier'. Replace occurrences of io.github.ja7ad.hydra.Hydra-Safari-Extension with io.github.ja7ad.hydra.safari in project.pbxproj. Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
VedantMadane
force-pushed
the
ci/safari-extension-build
branch
from
September 21, 2026 12:15
fdf1d53 to
d8eacb5
Compare
ja7ad
approved these changes
Sep 21, 2026
ja7ad
changed the title
Owner
|
@VedantMadane Thank you for contribution!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a GitHub Actions workflow to build, validate, and publish (as artifact) the Safari extension continuously.
Workflow (.github/workflows/safari-extension.yml)
Triggered on changes under extensions/**, the Safari build/sync scripts, or the workflow itself (also workflow_dispatch).
Notes
Test plan
Fixes #1