-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cooler support #504
Add cooler support #504
Conversation
Reviewer's Guide by SourceryThis pull request adds support for cooler functionality to the pyatmo library. The changes primarily affect the Room and Home classes, introducing new attributes and methods related to cooling operations. The implementation also includes updates to module mixins, constants, and test cases to accommodate the new cooling features. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @cgtobi - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding documentation or comments for the new cooling-related attributes, especially in the Room class, to explain their purpose and usage.
- It would be beneficial to add new test cases to cover the newly added cooling functionality and ensure proper test coverage.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟡 Complexity: 2 issues found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
8c791d2
to
4d71a7c
Compare
dd1a27c
to
7f11b6b
Compare
thanks for this! really waiting for it to be reviewed and merged 🙏 |
Summary by Sourcery
Add support for cooling systems by introducing new attributes and a CoolerMixin class. Enhance logging for better debugging and extend tests to cover new cooling functionality.
New Features:
Enhancements:
Tests: