Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test pypi action #505

Merged
merged 1 commit into from
Aug 18, 2024
Merged

fix test pypi action #505

merged 1 commit into from
Aug 18, 2024

Conversation

cgtobi
Copy link
Collaborator

@cgtobi cgtobi commented Aug 18, 2024

Summary by Sourcery

Correct the repository URL key format in the Test PyPI workflow to ensure proper functionality.

CI:

  • Fix the repository URL key in the Test PyPI workflow to use the correct format.

@cgtobi cgtobi requested a review from jabesq as a code owner August 18, 2024 22:02
Copy link

sourcery-ai bot commented Aug 18, 2024

Reviewer's Guide by Sourcery

This pull request makes minor adjustments to the GitHub Actions workflows for publishing packages to PyPI and TestPyPI. The changes primarily focus on formatting and correcting a parameter name in the TestPyPI publishing action.

File-Level Changes

Files Changes
.github/workflows/publish-to-pypi.yml Updated the tag format for triggering the PyPI publish action from 'v*' to "v*"
.github/workflows/publish-to-pypi.yml Adjusted formatting of commented-out TestPyPI publishing step in the PyPI workflow
.github/workflows/publish-to-pypi.yml
.github/workflows/publish-to-test-pypi.yml
Corrected the parameter name for the TestPyPI repository URL from 'repository_url' to 'repository-url' in both workflows
.github/workflows/publish-to-test-pypi.yml Removed an empty line in the TestPyPI workflow file

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cgtobi - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider removing the commented-out section for publishing to Test PyPI in publish-to-pypi.yml, or add a comment explaining why it's kept for future reference.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@@ -30,4 +29,4 @@ jobs:
uses: pypa/gh-action-pypi-publish@release/v1
with:
password: ${{ secrets.PYPI_TEST_TOKEN }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Critical fix for Test PyPI publishing

This change is crucial. The incorrect 'repository_url' parameter would have caused the workflow to fail when trying to publish to Test PyPI. Changing it to 'repository-url' fixes this potential issue and ensures successful publication to Test PyPI.

@cgtobi cgtobi merged commit 0b87f6c into development Aug 18, 2024
6 checks passed
@cgtobi cgtobi deleted the fix_ci branch August 18, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant