catch camera url update timeout

[adriencog]

On my NOC module, I'm experiencing timeout for local url. It makes whole home update throw.

Client already catches connectivity error, but timeout wasn't part of them.

Summary by Sourcery

Catch timeout errors in the camera URL update process to improve error handling and prevent disruptions in the home update process.

Bug Fixes:

• Handle timeout errors when updating camera URLs to prevent the entire home update process from failing.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request addresses a timeout issue in the NOC module by extending the exception handling in the async_update_camera_urls method. The change allows the method to catch TimeoutError in addition to the existing ClientConnectorError, preventing the whole home update from failing due to local URL timeouts.

File-Level Changes

Change	Details	Files
Extended exception handling to include TimeoutError	Added TimeoutError to the list of caught exceptions Maintained existing handling for ClientConnectorError	src/pyatmo/modules/module.py

---

Tips

• Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
• Continue your discussion with Sourcery by replying directly to review comments.
• You can change your review settings at any time by accessing your dashboard:
  • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
  • Change the review language;
• You can always contact us if you have any questions or feedback.

[sourcery-ai]

Hey @adriencog - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

[sourcery-ai]

suggestion: Consider modifying the logging to distinguish between timeout and connection errors.

The current logging doesn't differentiate between TimeoutError and ClientConnectorError. Consider updating the log message to provide more specific information about the type of error encountered. This could aid in debugging and monitoring.

Suggested change

	LOG.debug("Cannot connect to %s - reason: %s", temp_local_url, exc)
	if isinstance(exc, TimeoutError):
	LOG.debug("Timeout connecting to %s", temp_local_url)
	elif isinstance(exc, ClientConnectorError):
	LOG.debug("Connection error to %s - reason: %s", temp_local_url, exc)
	else:
	LOG.debug("Cannot connect to %s - reason: %s", temp_local_url, exc)

[cgtobi]

Please rather use separate exceptions instead of handling within a separate if statement.

[sourcery-ai]

Certainly, @cgtobi! Using separate except blocks for each exception type is a great approach for clarity and maintainability. It allows for more specific handling and logging of each error type. Here's how you could implement it:

try:
    self.local_url = await self._async_check_url(temp_local_url)
except TimeoutError:
    LOG.debug("Timeout connecting to %s", temp_local_url)
except ClientConnectorError as exc:
    LOG.debug("Connection error to %s - reason: %s", temp_local_url, exc)

This way, each exception is handled individually, making the code easier to read and the logs more informative. Let me know if you need further assistance!

[cgtobi]

Thanks for that fix. But please use separate exceptions than if.

[adriencog]

hi @cgtobi do you think it could be possible to create a 8.10.1 release with this fix ? 🙏