-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jaeger v2 with v1 #613
Jaeger v2 with v1 #613
Changes from 10 commits
22c8ade
7212b86
9e73b35
0dd3924
f7db758
b980560
d9aa942
01d341b
ee12ee4
3012649
1ea257d
42c30a0
f247a95
647f7fa
8069914
742febb
b6bbc4b
7a24558
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
apiVersion: v2 | ||
appVersion: 1.53.0 | ||
appVersion: 2.0.0-rc2 | ||
description: A Jaeger Helm chart for Kubernetes | ||
name: jaeger | ||
type: application | ||
version: 3.3.1 | ||
version: 3.3.2 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. maybe go to 4.x? It's not backwards compatible with chart-3.x which only works with jaeger-v1 |
||
# CronJobs require v1.21 | ||
kubeVersion: ">= 1.21-0" | ||
keywords: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
{{- if .Values.allInOne.enabled -}} | ||
yurishkuro marked this conversation as resolved.
Show resolved
Hide resolved
|
||
apiVersion: v1 | ||
kind: ConfigMap | ||
metadata: | ||
name: jaeger-configmap | ||
namespace: {{ include "jaeger.namespace" . }} | ||
labels: | ||
{{- include "jaeger.labels" . | nindent 4 }} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this much whitespace on the left expected? Could we use normal indentation
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. could you explain what do yo mean by "normal indentation" i used this format because that is how labels are indented thought-out the chart There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I showed example There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. oh got it will fix it |
||
data: | ||
config.yaml: | | ||
service: | ||
extensions: [{{ join ", " .Values.config.service.extensions }}] | ||
pipelines: | ||
traces: | ||
receivers: [{{ join ", " .Values.config.service.pipelines.traces.receivers }}] | ||
processors: [{{ join ", " .Values.config.service.pipelines.traces.processors }}] | ||
exporters: [{{ join ", " .Values.config.service.pipelines.traces.exporters }}] | ||
|
||
extensions: | ||
{{- include "jaeger.extensionsConfig" . | nindent 6 }} | ||
receivers: | ||
{{- include "jaeger.receiversConfig" . | nindent 6 }} | ||
processors: | ||
{{- include "jaeger.processorsConfig" . | nindent 6 }} | ||
exporters: | ||
{{- include "jaeger.exportersConfig" . | nindent 6 }} | ||
{{- end }} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -58,6 +58,8 @@ spec: | |
imagePullPolicy: {{ .Values.allInOne.image.pullPolicy }} | ||
name: jaeger | ||
args: | ||
- "--config" | ||
- "/etc/jaeger/config.yaml" | ||
{{- range $arg := .Values.allInOne.args }} | ||
- "{{ tpl $arg $ }}" | ||
{{- end }} | ||
|
@@ -80,11 +82,13 @@ spec: | |
protocol: TCP | ||
- containerPort: 4318 | ||
protocol: TCP | ||
- containerPort: 13133 | ||
protocol: TCP | ||
livenessProbe: | ||
failureThreshold: 5 | ||
httpGet: | ||
path: / | ||
port: 14269 | ||
path: /status | ||
port: 13133 | ||
scheme: HTTP | ||
initialDelaySeconds: 5 | ||
periodSeconds: 15 | ||
|
@@ -93,8 +97,8 @@ spec: | |
readinessProbe: | ||
failureThreshold: 3 | ||
httpGet: | ||
path: / | ||
port: 14269 | ||
path: /status | ||
port: 13133 | ||
scheme: HTTP | ||
initialDelaySeconds: 1 | ||
periodSeconds: 10 | ||
|
@@ -105,6 +109,8 @@ spec: | |
{{- toYaml . | nindent 12 }} | ||
{{- end }} | ||
volumeMounts: | ||
- name: jaeger-config | ||
mountPath: /etc/jaeger | ||
{{- if not .Values.storage.badger.ephemeral }} | ||
- name: badger-data | ||
mountPath: {{ .Values.storage.badger.persistence.mountPath }} | ||
|
@@ -123,6 +129,9 @@ spec: | |
{{- toYaml .Values.allInOne.podSecurityContext | nindent 8 }} | ||
serviceAccountName: {{ template "jaeger.fullname" . }} | ||
volumes: | ||
- name: jaeger-config | ||
configMap: | ||
name: jaeger-configmap | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please clean-up all the naming. Not jaeger-config, not jaeger-configmap, not There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done should i convert it to PR |
||
{{- if not .Values.storage.badger.ephemeral }} | ||
- name: badger-data | ||
persistentVolumeClaim: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line is hard to read, please use the same formatting as in the deleted sections, one flag per line