-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jaeger v2 with v1 #613
Merged
Merged
Jaeger v2 with v1 #613
Changes from 16 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
22c8ade
Jaeger allInOne allow different storage types (#603)
rgaduput 7212b86
Merge branch 'main' into jaeger-v2-with-v1
hellspawn679 9e73b35
minor changes
0dd3924
Merge branch 'jaeger-v2-with-v1' of https://github.com/hellspawn679/h…
f7db758
added image changes
b980560
fix lint
d9aa942
removed v1 allInOne and added jaeger-v2
01d341b
removed v2 references
ee12ee4
added allInOne again
3012649
minor fix
1ea257d
fixed how the config is being passed
42c30a0
fixed mirror template change
f247a95
use --set-file for user config
647f7fa
removed config-test and updated configmap template
8069914
fixed
742febb
Merge branch 'v2' into jaeger-v2-with-v1
hellspawn679 b6bbc4b
fixed minor naming
hellspawn679 7a24558
indentation
yurishkuro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,17 +38,6 @@ jobs: | |
- name: Run chart-testing (lint) | ||
run: ct lint --config ct.yaml | ||
|
||
test-with-cassandra: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
with: | ||
fetch-depth: 0 | ||
|
||
- uses: ./.github/actions/prepare-k8s | ||
|
||
- name: Run cassandra-chart-testing (install) | ||
run: ct install --config ct.yaml | ||
test-with-allInOne: | ||
runs-on: ubuntu-latest | ||
steps: | ||
|
@@ -58,32 +47,7 @@ jobs: | |
|
||
- uses: ./.github/actions/prepare-k8s | ||
|
||
- name: Run allInOne-chart-testing (install) | ||
- name: Run chart-testing (install) | ||
run: | | ||
ct install --config ct.yaml --helm-extra-set-args " | ||
--set provisionDataStore.cassandra=false | ||
--set storage.type=memory | ||
--set allInOne.enabled=true | ||
--set agent.enabled=false | ||
--set collector.enabled=false | ||
--set query.enabled=false" | ||
test-with-elasticsearch: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
with: | ||
fetch-depth: 0 | ||
|
||
- uses: ./.github/actions/prepare-k8s | ||
ct install --config ct.yaml --helm-extra-set-args "--set provisionDataStore.cassandra=false --set storage.type=memory --set allInOne.enabled=true --set agent.enabled=false --set collector.enabled=false --set query.enabled=false" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this line is hard to read, please use the same formatting as in the deleted sections, one flag per line |
||
|
||
- name: Run elasticsearch-chart-testing (install) | ||
run: | | ||
ct install --config ct.yaml --helm-extra-set-args " | ||
--set provisionDataStore.cassandra=false | ||
--set provisionDataStore.elasticsearch=true | ||
--set storage.type=elasticsearch | ||
--set elasticsearch.master.masterOnly=false | ||
--set elasticsearch.master.replicaCount=1 | ||
--set elasticsearch.data.replicaCount=0 | ||
--set elasticsearch.coordinating.replicaCount=0 | ||
--set elasticsearch.ingest.replicaCount=0" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
{{ if .Values.userconfig }} | ||
apiVersion: v1 | ||
kind: ConfigMap | ||
metadata: | ||
name: user-config | ||
namespace: {{ include "jaeger.namespace" . }} | ||
labels: | ||
{{- include "jaeger.labels" . | nindent 4 }} | ||
data: | ||
user-config.yaml: | | ||
{{- .Values.userconfig | nindent 4 }} | ||
yurishkuro marked this conversation as resolved.
Show resolved
Hide resolved
|
||
{{- end }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.