Removed commits

Signed-off-by: cs-308-2023 <[email protected]>
jaegertracing · Jan 11, 2025 · 95aa6bc · 95aa6bc
1 parent 99809eb
commit 95aa6bc
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 20 deletions.
diff --git a/package.json b/package.json
diff --git a/pkg/config/tlscfg/flags.go b/pkg/config/tlscfg/flags.go
@@ -57,9 +57,7 @@ func (c ServerFlagsConfig) AddFlags(flags *flag.FlagSet) {
 	flags.String(c.Prefix+tlsCipherSuites, "", "Comma-separated list of cipher suites for the server, values are from tls package constants (https://golang.org/pkg/crypto/tls/#pkg-constants).")
 	flags.String(c.Prefix+tlsMinVersion, "", "Minimum TLS version supported (Possible values: 1.0, 1.1, 1.2, 1.3)")
 	flags.String(c.Prefix+tlsMaxVersion, "", "Maximum TLS version supported (Possible values: 1.0, 1.1, 1.2, 1.3)")
-	// if c.EnableCertReloadInterval {
 	flags.Duration(c.Prefix+tlsReloadInterval, 0, "The duration after which the certificate will be reloaded (0s means will not be reloaded)")
-	// }
 }
 
 // InitFromViper creates tls.Config populated with values retrieved from Viper.

diff --git a/pkg/config/tlscfg/flags_test.go b/pkg/config/tlscfg/flags_test.go
@@ -146,11 +146,7 @@ func TestServerCertReloadInterval(t *testing.T) {
 				"--" + test.config.Prefix + ".tls.enabled=true",
 				"--" + test.config.Prefix + ".tls.reload-interval=24h",
 			})
-			// if !test.config.EnableCertReloadInterval {
-			// 	assert.ErrorContains(t, err, "unknown flag")
-			// } else {
 			require.NoError(t, err)
-			// }
 		})
 	}
 }