Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new grpc storage configuration to align with OTEL #5331

Merged
merged 30 commits into from
May 20, 2024

fix

e476ece
Select commit
Loading
Failed to load commit list.
Merged

Create new grpc storage configuration to align with OTEL #5331

fix
e476ece
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed May 12, 2024 in 0s

37.97% (target 94.40%)

View this Pull Request on Codecov

37.97% (target 94.40%)

Details

Codecov Report

Attention: Patch coverage is 86.36364% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 37.97%. Comparing base (84ea40e) to head (e476ece).

Files Patch % Lines
plugin/storage/grpc/config/config.go 90.47% 1 Missing and 1 partial ⚠️
...eger/internal/extension/jaegerstorage/extension.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5331       +/-   ##
===========================================
- Coverage   95.46%   37.97%   -57.50%     
===========================================
  Files         331      160      -171     
  Lines       16113     8361     -7752     
===========================================
- Hits        15383     3175    -12208     
- Misses        556     4880     +4324     
- Partials      174      306      +132     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.