Upgrade storage integration tests: DependencyReader to v2
#6477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzzk1
changed the title
DependencyReader to v2DependencyReader to v2
zzzk1
changed the title
DependencyReader to v2DependencyReader to v2
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6477 +/- ##
==========================================
+ Coverage 96.27% 96.29% +0.01%
==========================================
Files 372 372
Lines 21282 21282
==========================================
+ Hits 20490 20493 +3
+ Misses 605 603 -2
+ Partials 187 186 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zzzk1
force-pushed
the
DependencyReader-v2
branch
from
00a1398 to
7b7d69d
Compare
yurishkuro
added
the
changelog:ci
yurishkuro
reviewed
Jan 4, 2025
yurishkuro
reviewed
Jan 4, 2025
zzzk1
force-pushed
the
DependencyReader-v2
branch
2 times, most recently
from
7b500e1 to
0ac707b
Compare
Signed-off-by: zzzk1 <[email protected]>
Signed-off-by: zzzk1 <[email protected]>
Signed-off-by: zzzk1 <[email protected]>
Signed-off-by: zzzk1 <[email protected]>
Signed-off-by: zzzk1 <[email protected]>
zzzk1
force-pushed
the
DependencyReader-v2
branch
from
8b9ca78 to
5010140
Compare
zzzk1
commented
Jan 5, 2025
yurishkuro
reviewed
Jan 5, 2025
Signed-off-by: Yuri Shkuro <[email protected]>
yurishkuro
approved these changes
Jan 5, 2025
Signed-off-by: zzzk1 <[email protected]>
auto-merge was automatically disabled
January 6, 2025 08:34
Head branch was pushed to by a user without write access
yurishkuro
approved these changes
Jan 6, 2025
adityachopra29
pushed a commit
to adityachopra29/jaeger
that referenced
this pull request
Jan 9, 2025
…acing#6477) ## Which problem is this PR solving? - Subtask of jaegertracing#6366 ## Description of the changes - use `/storage_v2/depstore.Reader` replaces `/storage/dependencystore.Reader` ## How was this change tested? - ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [ ] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: zzzk1 <[email protected]> Signed-off-by: Yuri Shkuro <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]> Signed-off-by: adityachopra29 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
/storage_v2/depstore.Readerreplaces/storage/dependencystore.ReaderHow was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test