Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change collector's queue to use generics #6486

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Jan 5, 2025

Which problem is this PR solving?

Description of the changes

  • In order to allow the queue to carry both v1 and v2 data model, let's first make the queue strongly typed by using generics

How was this change tested?

  • unit tests, CI

Signed-off-by: Yuri Shkuro <[email protected]>
Copy link

codecov bot commented Jan 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.30%. Comparing base (b1153a0) to head (9ce427b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6486      +/-   ##
==========================================
- Coverage   96.30%   96.30%   -0.01%     
==========================================
  Files         372      372              
  Lines       21277    21276       -1     
==========================================
- Hits        20491    20490       -1     
  Misses        601      601              
  Partials      185      185              
Flag Coverage Δ
badger_v1 10.67% <ø> (ø)
badger_v2 2.78% <ø> (ø)
cassandra-4.x-v1-manual 16.51% <ø> (ø)
cassandra-4.x-v2-auto 2.71% <ø> (ø)
cassandra-4.x-v2-manual 2.71% <ø> (ø)
cassandra-5.x-v1-manual 16.51% <ø> (ø)
cassandra-5.x-v2-auto 2.71% <ø> (ø)
cassandra-5.x-v2-manual 2.71% <ø> (ø)
elasticsearch-6.x-v1 20.18% <ø> (ø)
elasticsearch-7.x-v1 20.25% <ø> (ø)
elasticsearch-8.x-v1 20.40% <ø> (ø)
elasticsearch-8.x-v2 2.77% <ø> (-0.01%) ⬇️
grpc_v1 12.30% <ø> (-0.01%) ⬇️
grpc_v2 9.09% <ø> (ø)
kafka-3.x-v1 10.35% <ø> (ø)
kafka-3.x-v2 2.78% <ø> (ø)
memory_v2 2.78% <ø> (ø)
opensearch-1.x-v1 20.29% <ø> (ø)
opensearch-2.x-v1 20.30% <ø> (+<0.01%) ⬆️
opensearch-2.x-v2 2.77% <ø> (ø)
tailsampling-processor 0.51% <ø> (ø)
unittests 95.18% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro marked this pull request as ready for review January 5, 2025 22:37
@yurishkuro yurishkuro requested a review from a team as a code owner January 5, 2025 22:37
@yurishkuro yurishkuro requested a review from jkowall January 5, 2025 22:37
@yurishkuro yurishkuro enabled auto-merge (squash) January 5, 2025 22:42
@yurishkuro yurishkuro merged commit 232d805 into jaegertracing:main Jan 6, 2025
55 of 56 checks passed
@yurishkuro yurishkuro deleted the generic-queue branch January 6, 2025 00:50
adityachopra29 pushed a commit to adityachopra29/jaeger that referenced this pull request Jan 9, 2025
## Which problem is this PR solving?
- Continuation of jaegertracing#6474

## Description of the changes
- In order to allow the queue to carry both v1 and v2 data model, let's
first make the queue strongly typed by using generics

## How was this change tested?
- unit tests, CI

---------

Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: adityachopra29 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants