Build: Fix windows for qt6.8.1 #3451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ann0see
reviewed
Dec 28, 2024
What if you just update the windows build manually and let #3407 focus only on bumping iOS only? Then we don't have build failures. |
Yup, that's the idea. |
pljones
force-pushed
the
fix-windows-for-qt6_8_1
branch
2 times, most recently
from
316144d to
1e56e54
Compare
ann0see
requested changes
Dec 29, 2024
pljones
force-pushed
the
fix-windows-for-qt6_8_1
branch
from
1e56e54 to
b06b66c
Compare
ann0see
reviewed
Dec 29, 2024
.github/workflows/autobuild.yml
Outdated
| @@ -251,7 +251,7 @@ jobs: | |||
| - config_name: iOS (artifacts) | |||
| target_os: ios | |||
| building_on_os: macos-14 | |||
| base_command: QT_VERSION=6.7.3 ./.github/autobuild/ios.sh | |||
There was a problem hiding this comment.
I would still prefer that the Qt upgrade for iOS remains untouched in this PR.
pljones
force-pushed
the
fix-windows-for-qt6_8_1
branch
from
b06b66c to
168acb5
Compare
pljones
force-pushed
the
fix-windows-for-qt6_8_1
branch
from
168acb5 to
f113ef1
Compare
ann0see
approved these changes
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
See #3407 for discussion.
This includes the ci bump commit on the branch, currently.
CHANGELOG: SKIP
Context: Fixes an issue?
See #3407 for discussion.
Leaves the iOS build broken. There doesn't seem to be any way to pin versions in the "Bump versions" workflow.
I've a branch here which reverts the iOS change but the "Bump versions" will just come and bump it again. (Build here.)
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Fixes the Windows builds.
What is missing until this pull request can be merged?
No.
Checklist
AUTOBUILD: Please build all targets