-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module-caching): loads module based on origin #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Samy-33
commented
Dec 24, 2024
•
edited
Loading
edited
jeaye
reviewed
Dec 24, 2024
jeaye
reviewed
Dec 24, 2024
jeaye
reviewed
Dec 24, 2024
jeaye
reviewed
Dec 25, 2024
jeaye
reviewed
Dec 25, 2024
jeaye
reviewed
Dec 25, 2024
jeaye
reviewed
Dec 25, 2024
Samy-33
force-pushed
the
feat/modules-by-source
branch
from
December 25, 2024 15:35
fdfd870
to
834dc16
Compare
Samy-33
force-pushed
the
feat/modules-by-source
branch
from
December 25, 2024 16:11
834dc16
to
11c03c4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #152 +/- ##
==========================================
- Coverage 57.01% 56.76% -0.25%
==========================================
Files 152 158 +6
Lines 18622 19038 +416
==========================================
+ Hits 10617 10807 +190
- Misses 8005 8231 +226 ☔ View full report in Codecov by Sentry. |
jeaye
reviewed
Dec 25, 2024
- Don't load clojure.core when compiling clojure.core itself. - Adds doc explaining why we are ignoring object files from archives.
Great job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.