Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module-caching): loads module based on origin #152

Merged
merged 4 commits into from
Dec 26, 2024

Conversation

Samy-33
Copy link
Contributor

@Samy-33 Samy-33 commented Dec 24, 2024

asciicast

@Samy-33 Samy-33 force-pushed the feat/modules-by-source branch from fdfd870 to 834dc16 Compare December 25, 2024 15:35
@Samy-33 Samy-33 force-pushed the feat/modules-by-source branch from 834dc16 to 11c03c4 Compare December 25, 2024 16:11
@Samy-33 Samy-33 requested a review from jeaye December 25, 2024 16:26
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 19.48052% with 62 lines in your changes missing coverage. Please review.

Project coverage is 56.76%. Comparing base (739ed59) to head (11c03c4).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
...ler+runtime/src/cpp/jank/runtime/module/loader.cpp 19.48% 62 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
- Coverage   57.01%   56.76%   -0.25%     
==========================================
  Files         152      158       +6     
  Lines       18622    19038     +416     
==========================================
+ Hits        10617    10807     +190     
- Misses       8005     8231     +226     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Don't load clojure.core when compiling clojure.core itself.
- Adds doc explaining why we are ignoring object files from archives.
@jeaye jeaye merged commit b80af01 into jank-lang:main Dec 26, 2024
2 of 3 checks passed
@jeaye
Copy link
Member

jeaye commented Dec 26, 2024

Great job!

@Samy-33 Samy-33 deleted the feat/modules-by-source branch December 26, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants