Skip to content

Feat(connectivity): add Turkey country list - #474

Draft
Mora140 wants to merge 1 commit into
jason5ng32:devfrom
Mora140:feat/connectivity-turkey
Draft

Mora140 wants to merge 1 commit into
jason5ng32:devfrom
Mora140:feat/connectivity-turkey

Conversation

@Mora140

@Mora140 Mora140 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Add a Turkey Essentials import list (Trendyol, Hepsiburada, Sahibinden, Eksi Sozluk, n11, Hurriyet, Milliyet, Yemeksepeti, Getir, Turkcell, Sabah, Akbank), locale names, and favicons.

Closes #398

Add a Turkey Essentials import list (Trendyol, Hepsiburada, Sahibinden, Eksi Sozluk, n11, Hurriyet, Milliyet, Yemeksepeti, Getir, Turkcell, Sabah, Akbank), locale names, and favicons.

Closes jason5ng32#398
Copilot AI lite review requested due to automatic review settings September 4, 2026 01:48
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

Thanks for another PR, @Mora140 — always good to see you back! 🙌

The maintainer will take a look shortly (usually within a day or two). As ever, pnpm check green locally is the fastest path through review.

This is an automated greeting; a human review follows.

@greptile-apps

greptile-apps Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds a localized Turkey Essentials connectivity import list with 12 Turkish services and corresponding favicon assets.

  • Registers the Turkey list and its connectivity targets.
  • Adds the list label to every supported full locale.
  • Adds matching favicon assets for all new members.

Confidence Score: 5/5

The PR appears safe to merge with no actionable correctness or security issues identified.

The new curated list stays within import limits, uses distinct target identities, supplies matching favicon filenames, and defines its display key across every registered full locale.

Important Files Changed

Filename Overview
frontend/data/connectivity-import-lists.js Adds a 12-member Turkey curated list whose IDs, hostnames, capacity, locale key, and favicon filenames align with existing import contracts.
frontend/locales/en.json Adds the English Turkey Essentials label used by the import-list UI.
frontend/locales/fr.json Adds the French Turkey list label while preserving full-locale key parity.
frontend/locales/pt-BR.json Adds the Brazilian Portuguese Turkey list label while preserving full-locale key parity.
frontend/locales/ru.json Adds the Russian Turkey list label while preserving full-locale key parity.
frontend/locales/zh-TW.json Adds the Traditional Chinese Turkey list label while preserving full-locale key parity.
frontend/locales/zh.json Adds the Simplified Chinese Turkey list label while preserving full-locale key parity.
public/favicons/trendyol.png Adds one of the matching static favicon assets; all 12 expected member filenames are present.

Reviews (1): Last reviewed commit: "Feat(connectivity): add Turkey country l..." | Re-trigger Greptile

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The new import list and locale keys are consistent with existing patterns and satisfy the full-locale coverage expectations for Connectivity import list names.

Pull request overview

Adds a new curated “Turkey Essentials” Connectivity import list to the Vue frontend, along with localized display names across all full locale packs so the list can be selected from the Connectivity import dialog.

Changes:

  • Added a new IMPORT_LISTS entry for id: 'turkey' with 🇹🇷 and 12 Turkey-focused members.
  • Added connectivity.importLists.turkey translations to all full locale JSON packs (en, fr, pt-BR, ru, zh, zh-TW).
File summaries
File Description
frontend/data/connectivity-import-lists.js Introduces the new turkey import list and its member definitions (ids + favicon URLs).
frontend/locales/en.json Adds localized label for connectivity.importLists.turkey.
frontend/locales/fr.json Adds localized label for connectivity.importLists.turkey.
frontend/locales/pt-BR.json Adds localized label for connectivity.importLists.turkey.
frontend/locales/ru.json Adds localized label for connectivity.importLists.turkey.
frontend/locales/zh.json Adds localized label for connectivity.importLists.turkey.
frontend/locales/zh-TW.json Adds localized label for connectivity.importLists.turkey.
Review details
  • Files reviewed: 7/19 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@jason5ng32
jason5ng32 marked this pull request as draft September 5, 2026 13:28
@jason5ng32 jason5ng32 added the needs-local-review Country list waiting for verification by someone who lives there label Sep 5, 2026
@jason5ng32

Copy link
Copy Markdown
Owner

Thanks for putting this together. Before we can take a country list, it needs to come from — or be verified by — someone who actually lives in that country. That's the whole premise of the list issues ("only a local knows which sites actually matter"): a connectivity list is about what people there use every day, not a popularity ranking, and that difference is exactly what an outside view tends to miss.

If you're based in Turkey or use its internet daily, just say so here and we'll review as normal. Otherwise this PR is converted to a draft and tagged needs-local-review, and #398 now points here so a local can verify the members instead of building a list from scratch. Nothing is wrong with the PR mechanically; it's simply waiting for a local reviewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-local-review Country list waiting for verification by someone who lives there

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants