Skip to content

Feat(connectivity): add Argentina country list - #480

Draft
Mora140 wants to merge 1 commit into
jason5ng32:devfrom
Mora140:feat/connectivity-argentina
Draft

Mora140 wants to merge 1 commit into
jason5ng32:devfrom
Mora140:feat/connectivity-argentina

Conversation

@Mora140

@Mora140 Mora140 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Feat(connectivity): add Argentina country list

Add an Argentina Essentials import list (Clarin, La Nacion, Infobae, TN, Despegar, AFIP, Banco Galicia, Mercado Libre Argentina, Fravega, Coto, OLX Argentina, PedidosYa), locale names, and favicons.

Related to #452

Add an Argentina Essentials import list (Clarin, La Nacion, Infobae, TN, Despegar, AFIP, Banco Galicia, Mercado Libre Argentina, Fravega, Coto, OLX Argentina, PedidosYa), locale names, and favicons.

Related to jason5ng32#452
Copilot AI lite review requested due to automatic review settings September 4, 2026 01:56
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

Thanks for another PR, @Mora140 — always good to see you back! 🙌

The maintainer will take a look shortly (usually within a day or two). As ever, pnpm check green locally is the fastest path through review.

This is an automated greeting; a human review follows.

@greptile-apps

greptile-apps Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds an Argentina Essentials connectivity import list with localized labels and bundled favicon assets.

  • Adds 12 Argentina-focused connectivity targets.
  • Adds the list label to all six full locale packs.
  • Adds matching favicon assets for every new target.

Confidence Score: 5/5

The PR appears safe to merge with no actionable correctness or security issues identified.

The new catalog entry has matching locale keys across every full locale and a committed favicon for each member, while its target shapes and hostnames conform to the existing import and deduplication contracts.

Important Files Changed

Filename Overview
frontend/data/connectivity-import-lists.js Adds a valid 12-member Argentina list whose IDs, HTTPS URLs, hostnames, and favicon references follow existing catalog conventions.
frontend/locales/en.json Adds the English label matching the new Argentina list ID.
frontend/locales/fr.json Adds the French label matching the new Argentina list ID.
frontend/locales/pt-BR.json Adds the Brazilian Portuguese label matching the new Argentina list ID.
frontend/locales/ru.json Adds the Russian label matching the new Argentina list ID.
frontend/locales/zh-TW.json Adds the Traditional Chinese label matching the new Argentina list ID.
frontend/locales/zh.json Adds the Simplified Chinese label matching the new Argentina list ID.
public/favicons/olx-ar.png Adds the locally served favicon corresponding to the new olx-ar member ID.

Reviews (1): Last reviewed commit: "Feat(connectivity): add Argentina countr..." | Re-trigger Greptile

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The new curated list and its locale keys follow the existing Connectivity list structure and satisfy the issue requirements without introducing risky logic changes.

Pull request overview

Adds an Argentina-focused curated Connectivity import list to the Vue frontend, making it available in the “Add Test” import dialog alongside existing country/theme lists.

Changes:

  • Added a new argentina curated import list (🇦🇷) with 12 Argentina-relevant targets.
  • Added localized display names for the new list across all full locale packs (en, zh, zh-TW, fr, ru, pt-BR).
File summaries
File Description
frontend/data/connectivity-import-lists.js Adds the new 🇦🇷 Argentina curated import list and its members.
frontend/locales/en.json Adds connectivity.importLists.argentina (“Argentina Essentials”).
frontend/locales/fr.json Adds the Argentina list name in French.
frontend/locales/pt-BR.json Adds the Argentina list name in Brazilian Portuguese.
frontend/locales/ru.json Adds the Argentina list name in Russian.
frontend/locales/zh.json Adds the Argentina list name in Simplified Chinese.
frontend/locales/zh-TW.json Adds the Argentina list name in Traditional Chinese.
Review details
  • Files reviewed: 7/19 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@jason5ng32
jason5ng32 marked this pull request as draft September 5, 2026 13:28
@jason5ng32 jason5ng32 added the needs-local-review Country list waiting for verification by someone who lives there label Sep 5, 2026
@jason5ng32

Copy link
Copy Markdown
Owner

Thanks for putting this together. Before we can take a country list, it needs to come from — or be verified by — someone who actually lives in that country. That's the whole premise of the list issues ("only a local knows which sites actually matter"): a connectivity list is about what people there use every day, not a popularity ranking, and that difference is exactly what an outside view tends to miss.

If you're based in Argentina or use its internet daily, just say so here and we'll review as normal. Otherwise this PR is converted to a draft and tagged needs-local-review, and #452 now points here so a local can verify the members instead of building a list from scratch. Nothing is wrong with the PR mechanically; it's simply waiting for a local reviewer.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-local-review Country list waiting for verification by someone who lives there

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants