Conversation
Add an Argentina Essentials import list (Clarin, La Nacion, Infobae, TN, Despegar, AFIP, Banco Galicia, Mercado Libre Argentina, Fravega, Coto, OLX Argentina, PedidosYa), locale names, and favicons. Related to jason5ng32#452
|
Thanks for another PR, @Mora140 — always good to see you back! 🙌 The maintainer will take a look shortly (usually within a day or two). As ever, This is an automated greeting; a human review follows. |
Greptile SummaryAdds an Argentina Essentials connectivity import list with localized labels and bundled favicon assets.
Confidence Score: 5/5The PR appears safe to merge with no actionable correctness or security issues identified. The new catalog entry has matching locale keys across every full locale and a committed favicon for each member, while its target shapes and hostnames conform to the existing import and deduplication contracts.
|
| Filename | Overview |
|---|---|
| frontend/data/connectivity-import-lists.js | Adds a valid 12-member Argentina list whose IDs, HTTPS URLs, hostnames, and favicon references follow existing catalog conventions. |
| frontend/locales/en.json | Adds the English label matching the new Argentina list ID. |
| frontend/locales/fr.json | Adds the French label matching the new Argentina list ID. |
| frontend/locales/pt-BR.json | Adds the Brazilian Portuguese label matching the new Argentina list ID. |
| frontend/locales/ru.json | Adds the Russian label matching the new Argentina list ID. |
| frontend/locales/zh-TW.json | Adds the Traditional Chinese label matching the new Argentina list ID. |
| frontend/locales/zh.json | Adds the Simplified Chinese label matching the new Argentina list ID. |
| public/favicons/olx-ar.png | Adds the locally served favicon corresponding to the new olx-ar member ID. |
Reviews (1): Last reviewed commit: "Feat(connectivity): add Argentina countr..." | Re-trigger Greptile
There was a problem hiding this comment.
🟢 Approval recommended
The new curated list and its locale keys follow the existing Connectivity list structure and satisfy the issue requirements without introducing risky logic changes.
Pull request overview
Adds an Argentina-focused curated Connectivity import list to the Vue frontend, making it available in the “Add Test” import dialog alongside existing country/theme lists.
Changes:
- Added a new
argentinacurated import list (🇦🇷) with 12 Argentina-relevant targets. - Added localized display names for the new list across all full locale packs (en, zh, zh-TW, fr, ru, pt-BR).
File summaries
| File | Description |
|---|---|
| frontend/data/connectivity-import-lists.js | Adds the new 🇦🇷 Argentina curated import list and its members. |
| frontend/locales/en.json | Adds connectivity.importLists.argentina (“Argentina Essentials”). |
| frontend/locales/fr.json | Adds the Argentina list name in French. |
| frontend/locales/pt-BR.json | Adds the Argentina list name in Brazilian Portuguese. |
| frontend/locales/ru.json | Adds the Argentina list name in Russian. |
| frontend/locales/zh.json | Adds the Argentina list name in Simplified Chinese. |
| frontend/locales/zh-TW.json | Adds the Argentina list name in Traditional Chinese. |
Review details
- Files reviewed: 7/19 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Thanks for putting this together. Before we can take a country list, it needs to come from — or be verified by — someone who actually lives in that country. That's the whole premise of the list issues ("only a local knows which sites actually matter"): a connectivity list is about what people there use every day, not a popularity ranking, and that difference is exactly what an outside view tends to miss. If you're based in Argentina or use its internet daily, just say so here and we'll review as normal. Otherwise this PR is converted to a draft and tagged |
Feat(connectivity): add Argentina country list
Add an Argentina Essentials import list (Clarin, La Nacion, Infobae, TN, Despegar, AFIP, Banco Galicia, Mercado Libre Argentina, Fravega, Coto, OLX Argentina, PedidosYa), locale names, and favicons.
Related to #452