Skip to content

Commit

Permalink
bump playwright to 1.49.1 including override (#873)
Browse files Browse the repository at this point in the history
* bump playwright to 1.49.1 including override

* try removing assertion

* is nested step cursed?
  • Loading branch information
jbolda authored Dec 10, 2024
1 parent 4d89195 commit ac6e374
Show file tree
Hide file tree
Showing 4 changed files with 48 additions and 51 deletions.
84 changes: 42 additions & 42 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,16 +48,16 @@
"react-dom": "18.3.1"
},
"@estruyf/github-actions-reporter": {
"@playwright/test": "^1.43.0"
"@playwright/test": "^1.49.1"
}
},
"@parcel/resolver-default": {
"packageExports": true
},
"devDependencies": {
"@estruyf/github-actions-reporter": "^1.9.2",
"@playwright/experimental-ct-react17": "^1.49.0",
"@playwright/test": "^1.49.0",
"@playwright/experimental-ct-react17": "^1.49.1",
"@playwright/test": "^1.49.1",
"@tauri-apps/cli": "2.1.0",
"@trivago/prettier-plugin-sort-imports": "^4.3.0",
"@types/d3": "^7.4.3",
Expand Down
1 change: 0 additions & 1 deletion tests/helpers/elements.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ export const selectOption = (page: Page, label: string, option: string) =>
await expect(async () => {
await selectInput.scrollIntoViewIfNeeded();
await selectInput.click();
await expect(page.getByRole('option', { name: option })).toBeInViewport();
await page.getByRole('option', { name: option }).click();
}).toPass();
});
Expand Down
8 changes: 3 additions & 5 deletions tests/transactions/helper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,9 @@ export const addGenericTransaction = async (
});

if (extraActions) {
await test.step('Extra Actions', async () => {
for (let pageAction of extraActions) {
await pageAction;
}
});
for (let pageAction of extraActions) {
await pageAction;
}
}

await page.getByLabel('value').first().fill(value);
Expand Down

0 comments on commit ac6e374

Please sign in to comment.