Remove dead code

- Remove #items from DTReRunConfiguration because this is never called (I checked) and calls dead code - Remove printing methods from KeyMapping because they call dead code, cannot work and are never called - Fix deprecation in SpRubFindReplaceDialog Fixes pharo-project#17606 Fixes pharo-project#17609
jecisc · Jan 17, 2025 · 4eb53e4 · 4eb53e4
1 parent 3bdc17f
commit 4eb53e4
Show file tree

Hide file tree

Showing 11 changed files with 24 additions and 87 deletions.
diff --git a/src/DrTests/DTReRunConfiguration.class.st b/src/DrTests/DTReRunConfiguration.class.st
@@ -29,11 +29,6 @@ DTReRunConfiguration >> configurationToRun: anObject [
 	configurationToRun := anObject
 ]
 
-{ #category : 'accessing' }
-DTReRunConfiguration >> items [
-	^ { self testToReRun }
-]
-
 { #category : 'accessing' }
 DTReRunConfiguration >> originalConfiguration [
 	^ originalConfiguration

diff --git a/src/Keymapping-KeyCombinations/KMAltModifier.class.st b/src/Keymapping-KeyCombinations/KMAltModifier.class.st
@@ -24,8 +24,3 @@ KMAltModifier >> initialize [
 KMAltModifier >> matchesEvent: aKeyboardEvent [
 	^ aKeyboardEvent altKeyPressed
 ]
-
-{ #category : 'printing' }
-KMAltModifier >> printingPosition [
-	^2
-]
diff --git a/src/Keymapping-KeyCombinations/KMCommandModifier.class.st b/src/Keymapping-KeyCombinations/KMCommandModifier.class.st
@@ -24,8 +24,3 @@ KMCommandModifier >> initialize [
 KMCommandModifier >> matchesEvent: aKeyboardEvent [
 	^  aKeyboardEvent commandKeyPressed
 ]
-
-{ #category : 'printing' }
-KMCommandModifier >> printingPosition [
-	^1
-]
diff --git a/src/Keymapping-KeyCombinations/KMComposedModifier.class.st b/src/Keymapping-KeyCombinations/KMComposedModifier.class.st
@@ -85,15 +85,6 @@ KMComposedModifier >> printOn: aStream [
 		separatedBy: [ aStream << ' + ' ]
 ]
 
-{ #category : 'printing' }
-KMComposedModifier >> printOsRepresentationOn: aStream [
-	| modifiersSorted |
-	modifiersSorted := modifiers asSortedCollection: [ : a : b | a printingPosition < b printingPosition ].
-	modifiersSorted
-		do: [ :modifier| modifier printOsRepresentationOn: aStream ]
-		separatedBy: [ aStream << $+ ]
-]
-
 { #category : 'combining' }
 KMComposedModifier >> shift [
 	modifiers add: KMModifier shift

diff --git a/src/Keymapping-KeyCombinations/KMCtrlModifier.class.st b/src/Keymapping-KeyCombinations/KMCtrlModifier.class.st
@@ -24,8 +24,3 @@ KMCtrlModifier >> initialize [
 KMCtrlModifier >> matchesEvent: aKeyboardEvent [
 	^ aKeyboardEvent controlKeyPressed
 ]
-
-{ #category : 'printing' }
-KMCtrlModifier >> printingPosition [
-	^3
-]
diff --git a/src/Keymapping-KeyCombinations/KMKeyCombination.class.st b/src/Keymapping-KeyCombinations/KMKeyCombination.class.st
@@ -146,19 +146,6 @@ KMKeyCombination >> prettyPrintOn: aStream [
 	self shortcut character name printOn: aStream
 ]
 
-{ #category : 'printing' }
-KMKeyCombination >> printOsRepresentation [
-	^String streamContents: [ : stream | self printOsRepresentationOn: stream ]
-]
-
-{ #category : 'printing' }
-KMKeyCombination >> printOsRepresentationOn: aStream [
-	self shortcut modifier ifNotNil: [: modifier |
-		modifier printOsRepresentationOn: aStream.
-		aStream << $+].
-	self shortcut character printOn: aStream
-]
-
 { #category : 'accessing' }
 KMKeyCombination >> shortcut [
 	^self

diff --git a/src/Keymapping-KeyCombinations/KMMetaModifier.class.st b/src/Keymapping-KeyCombinations/KMMetaModifier.class.st
@@ -50,13 +50,3 @@ KMMetaModifier >> matches: aKeyboardEvent [
 KMMetaModifier >> matchesEvent: aKeyboardEvent [
 	^ OSPlatform current defaultModifier matchesEvent: aKeyboardEvent
 ]
-
-{ #category : 'printing' }
-KMMetaModifier >> printOsRepresentationOn: aStream [
-	aStream << Smalltalk os menuShortcutModifierString
-]
-
-{ #category : 'printing' }
-KMMetaModifier >> printingPosition [
-	^1
-]
diff --git a/src/Keymapping-KeyCombinations/KMModifier.class.st b/src/Keymapping-KeyCombinations/KMModifier.class.st
@@ -105,16 +105,6 @@ KMModifier >> printOn: aStream [
 	aStream << name
 ]
 
-{ #category : 'printing' }
-KMModifier >> printOsRepresentationOn: aStream [
-	aStream << name asLowercase
-]
-
-{ #category : 'printing' }
-KMModifier >> printingPosition [
-	^self subclassResponsibility
-]
-
 { #category : 'private' }
 KMModifier >> species [
 

diff --git a/src/Keymapping-KeyCombinations/KMShiftModifier.class.st b/src/Keymapping-KeyCombinations/KMShiftModifier.class.st
@@ -24,8 +24,3 @@ KMShiftModifier >> initialize [
 KMShiftModifier >> matchesEvent: aKeyboardEvent [
 	^ aKeyboardEvent shiftPressed
 ]
-
-{ #category : 'printing' }
-KMShiftModifier >> printingPosition [
-	^4
-]
diff --git a/src/ReleaseTests/ReleaseTest.class.st b/src/ReleaseTests/ReleaseTest.class.st
@@ -540,13 +540,13 @@ ReleaseTest >> testThatThereAreNoSelectorsRemainingThatAreSentButNotImplemented
 	                    'AthensPolygon>>#paintFillsUsing:on:' 'BalloonEdgeData>>#stepToFirstScanLine' 'BalloonEdgeData>>#stepToNextScanLine'
 	                    'BalloonEngine>>#registerFills:' 'BalloonFillData>>#computeFill' 'ClyFullBrowserMorph>>#extendClassScopeForMethods:'
 	                    'ComplexBorderStyle>>#drawPolyPatchFrom:to:on:usingEnds:' 'ComplexBorderStyle>>#drawLineFrom:to:on:'
-	                    'Context>>#doPrimitive:method:receiver:args:' 'Context>>#failPrimitiveWith:' 'DTReRunConfiguration>>#items' 'DebugSession>>#shouldDisplayContext:basedOnFilters:'
+	                    'Context>>#doPrimitive:method:receiver:args:' 'Context>>#failPrimitiveWith:' 'DebugSession>>#shouldDisplayContext:basedOnFilters:'
 	                    'EDTest>>#prepareMethodVersionTest' 'ExternalDropHandler class>>#defaultHandler' 'FFICallbackArgumentReader>>#stackPointer'
 	                    'FFIFloat32>>#callbackReturnOn:for:' 'FFIFloatType>>#callbackReturnOn:for:' 'FFIIndirectFunctionResolution>>#resolveFunction:'
 	                    'OCIRReconstructor>>#fixPushNilsForTemps' 'IceTipHiedraAltComponentHistoryBrowser>>#newCommitRow:commit:'
 	                    'IceTipHiedraAltHistoryBrowser>>#newCommitRow:commit:' 'IceTipHiedraAltHistoryBrowser>>#initializeCommitList'
 	                    'InstructionStream>>#interpretNext3ByteSistaV1Instruction:for:extA:extB:startPC:'
-	                    'KMMetaModifier>>#printOsRepresentationOn:' 'LazyListMorph>>#drawOnAthensCanvas:' 'MCFileTreeAbstractReader>>#packageProperties'
+	                    'LazyListMorph>>#drawOnAthensCanvas:' 'MCFileTreeAbstractReader>>#packageProperties'
 	                    'MicrodownSpecComponentForTest class>>#open' 'MorphTreeMorph>>#nodeExpandRequest:' 'MorphTreeMorph>>#selectItemsRequest:'
 	                    'PSMCClassChangeWrapper>>#remoteChosen' 'PolygonMorph>>#intersects:' 'RBBasicDummyLintRuleTest class>>#createMatcherFor:method:'
 	                    'RBBasicDummyLintRuleTest class>>#usesAdd' 'RBBasicDummyLintRuleTest class>>#unreferencedVariables'

diff --git a/src/Rubric-SpecFindReplaceDialog/SpRubFindReplaceDialog.class.st b/src/Rubric-SpecFindReplaceDialog/SpRubFindReplaceDialog.class.st
@@ -25,32 +25,36 @@ Class {
 
 { #category : 'layout' }
 SpRubFindReplaceDialog class >> defaultLayout [
+
 	<spec>
 	^ SpBoxLayout newVertical
-		add: #findInput expand: false;
-		add: (SpGridLayout new
-			beColumnHomogeneous;
-			beRowHomogeneous;
-			add: #regExpCheckBox at: 1@1;
-			add: #backwardsCheckBox at: 2@1;
-			add: #caseCheckBox at: 1@2;
-			add: #wrapCheckBox at: 2@2;
-			add: #entireCheckBox at: 1@3;
-			yourself);
-		addLast: (SpBoxLayout newHorizontal
-			borderWidth: 5;
-			spacing: 5;
-			add: #replaceLabel  expand: false fill: false padding: 0;
-			add: #replaceTextInput;
-			yourself);
-		"addLast: (SpBoxLayout newHorizontal
+		  add: #findInput expand: false;
+		  add: (SpGridLayout new
+				   beColumnHomogeneous;
+				   beRowHomogeneous;
+				   add: #regExpCheckBox atPoint: 1 @ 1;
+				   add: #backwardsCheckBox at: 2 @ 1;
+				   add: #caseCheckBox at: 1 @ 2;
+				   add: #wrapCheckBox at: 2 @ 2;
+				   add: #entireCheckBox at: 1 @ 3;
+				   yourself);
+		  addLast: (SpBoxLayout newHorizontal
+				   borderWidth: 5;
+				   spacing: 5;
+				   add: #replaceLabel
+				   expand: false
+				   fill: false
+				   padding: 0;
+				   add: #replaceTextInput;
+				   yourself);
+		  "addLast: (SpBoxLayout newHorizontal
 			borderWidth: 3;
 			spacing: 5;
 			add: #findButton;
 			add: #replaceButton;
 			add: #replaceAllButton;
 			add: #cancelButton);"
-		yourself
+			  yourself
 ]
 
 { #category : 'morphic dependencies' }