Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency hotkeys-js to v3.13.9 #10072

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update dependency hotkeys-js to v3.13.9 #10072

wants to merge 1 commit into from
+6 −6

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 17, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
hotkeys-js (source) 3.12.2 -> 3.13.9 age adoption passing confidence

Release Notes

jaywcjlove/hotkeys-js (hotkeys-js)

v3.13.9

Compare Source

Buy me a coffee npm bundle size npm version

Documentation v3.13.9: https://raw.githack.com/jaywcjlove/hotkeys/b3cb4a3/index.html\
Comparing Changes: jaywcjlove/hotkeys-js@v3.13.8...v3.13.9

npm i [email protected]

v3.13.8

Compare Source

Buy me a coffee npm bundle size npm version

Documentation v3.13.8: https://raw.githack.com/jaywcjlove/hotkeys/9c0d12f/index.html\
Comparing Changes: jaywcjlove/hotkeys-js@v3.13.8...v3.13.8

npm i [email protected]

v3.13.7

Compare Source

Buy me a coffee npm bundle size npm version

Documentation v3.13.7: https://raw.githack.com/jaywcjlove/hotkeys/116a4c6/index.html\
Comparing Changes: jaywcjlove/hotkeys-js@v3.13.7...v3.13.7

npm i [email protected]
  • 💢 ci: update workflows config. b003877

v3.13.6

Compare Source

Buy me a coffee npm bundle size npm version

Documentation v3.13.6: https://raw.githack.com/jaywcjlove/hotkeys/13069ba/index.html\
Comparing Changes: jaywcjlove/hotkeys-js@v3.13.5...v3.13.6

npm i [email protected]

v3.13.5

Compare Source

Buy me a coffee npm bundle size npm version

Documentation v3.13.5: https://raw.githack.com/jaywcjlove/hotkeys/6171e4b/index.html\
Comparing Changes: jaywcjlove/hotkeys-js@v3.13.4...v3.13.5

npm i [email protected]

v3.13.4

Compare Source

Buy me a coffee npm bundle size npm version

Documentation v3.13.4: https://raw.githack.com/jaywcjlove/hotkeys/f8e5498/index.html\
Comparing Changes: jaywcjlove/hotkeys-js@v3.13.3...v3.13.4

npm i [email protected]

v3.13.3

Compare Source

Buy me a coffee npm bundle size npm version

Documentation v3.13.3: https://raw.githack.com/jaywcjlove/hotkeys/46b6f09/index.html\
Comparing Changes: jaywcjlove/hotkeys-js@v3.13.2...v3.13.3

npm i [email protected]

v3.13.2

Compare Source

Buy me a coffee npm bundle size npm version

Documentation v3.13.2: https://raw.githack.com/jaywcjlove/hotkeys/023934e/index.html\
Comparing Changes: jaywcjlove/hotkeys-js@v3.13.1...v3.13.2

npm i [email protected]

v3.13.1

Compare Source

Buy me a coffee npm bundle size npm version

Documentation v3.13.1: https://raw.githack.com/jaywcjlove/hotkeys/3f93f05/index.html\
Comparing Changes: jaywcjlove/hotkeys-js@v3.13.0...v3.13.1

npm i [email protected]

v3.13.0

Compare Source

Buy me a coffee npm bundle size npm version

Documentation v3.13.0: https://raw.githack.com/jaywcjlove/hotkeys/ada9a13/index.html\
Comparing Changes: jaywcjlove/hotkeys-js@v3.12.2...v3.13.0

npm i [email protected]

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code, used by dependency tooling skip-changelog Should not be shown in the changelog labels Dec 17, 2024
@renovate renovate bot requested a review from a team December 17, 2024 23:38
MarkEWaite
MarkEWaite requested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to block this change until the plugin BOM related issues are resolved:

@timja
Copy link
Member

timja commented Dec 18, 2024

cc @janfaracik I'm guessing nothing changed in the library and either command palette or keyboard shortcuts tweaking PR changed how it was being interacted with so the core tests no longer failed.

@A1exKH
Copy link

A1exKH commented Dec 24, 2024

Need to block this change until the plugin BOM related issues are resolved:

* [Update dependency org.jenkins-ci.main:jenkins-war to v2.491 bom#4114 (comment)](https://github.com/jenkinsci/bom/pull/4114#issuecomment-2549650538)

@MarkEWaite this issue was fixed / merged.

A1exKH
A1exKH approved these changes Dec 24, 2024
View reviewed changes
Copy link

@A1exKH A1exKH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarkEWaite @timja
This PR LGTM.
Linked issue was merged.

@krisstern
Copy link
Member

jenkinsci/bom#4118

@krisstern krisstern requested a review from MarkEWaite January 6, 2025 17:32
krisstern
krisstern previously approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@krisstern krisstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright to me

@timja
Copy link
Member

timja commented Jan 6, 2025

Looks alright to me

I highly doubt it is

@krisstern
Copy link
Member

Looks alright to me

I highly doubt it is

Is there any other outstanding issues with this PR then?

@timja
Copy link
Member

timja commented Jan 6, 2025

Need to block this change until the plugin BOM related issues are resolved:

This, the issue was reverted not resolved

@krisstern krisstern self-requested a review January 6, 2025 18:20
@krisstern krisstern dismissed their stale review January 6, 2025 18:20

Premature

@krisstern
Copy link
Member

krisstern commented Jan 6, 2025 •
edited
Loading

Need to block this change until the plugin BOM related issues are resolved:

This, the issue was reverted not resolved

Ah, I see the difference now! Thanks, Tim

@krisstern krisstern requested review from a team and removed request for krisstern January 6, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@A1exKH A1exKH A1exKH approved these changes

@krisstern krisstern krisstern left review comments

@MarkEWaite MarkEWaite Awaiting requested review from MarkEWaite

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code, used by dependency tooling skip-changelog Should not be shown in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@timja @A1exKH @krisstern @MarkEWaite