Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tailscale to 1.78.1 #2963

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

fl0x53
Copy link
Contributor

@fl0x53 fl0x53 commented Dec 20, 2024

Description

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Alternate Designs

Possible Drawbacks

Verification Process

Release Notes

Contributing checklist

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING and LICENSE document.
  • I fully agree to distribute my changes under Apache 2.0 license.

Summary by CodeRabbit

  • New Features

    • Updated Tailscale package to version 1.78.1, improving performance and security.
  • Bug Fixes

    • Resolved issues related to the previous version of Tailscale (1.76.6).
  • Documentation

    • Updated version references for Tailscale in relevant documentation.

Copy link

coderabbitai bot commented Dec 20, 2024

Walkthrough

This pull request updates the Tailscale package in the buildroot-external configuration from version 1.76.6 to 1.78.1. The changes involve modifying two files: tailscale.hash and tailscale.mk. The hash file is updated with new SHA256 checksums for the Tailscale binary across four different architectures (amd64, 386, arm, and arm64), while the makefile is updated to reflect the new version number and corresponding source file names.

Changes

File Change Summary
buildroot-external/package/tailscale/tailscale.hash Updated SHA256 hashes for Tailscale version 1.78.1 across architectures (amd64, 386, arm, arm64)
buildroot-external/package/tailscale/tailscale.mk Updated TAILSCALE_VERSION from 1.76.6 to 1.78.1 and adjusted source file names for different architectures

Possibly related PRs

  • Update Tailscale v1.76.1 #2882: Previous Tailscale package update from version 1.76.0 to 1.76.1, showing a pattern of incremental version updates for the Tailscale package

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bcf7eaf and 2910f45.

📒 Files selected for processing (2)
  • buildroot-external/package/tailscale/tailscale.hash (1 hunks)
  • buildroot-external/package/tailscale/tailscale.mk (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • buildroot-external/package/tailscale/tailscale.hash
🔇 Additional comments (3)
buildroot-external/package/tailscale/tailscale.mk (3)

Line range hint 9-16: Architecture mappings are correctly maintained

The source file mappings for each architecture are properly updated with the new version while maintaining the correct Tailscale architecture naming conventions:

  • arm (BR2_ARCH) → arm.tgz
  • aarch64 (BR2_ARCH) → arm64.tgz
  • i686 (BR2_ARCH) → 386.tgz
  • x86_64 (BR2_ARCH) → amd64.tgz

7-7: Verify Tailscale version 1.78.1 availability and stability

The version update matches the PR objective. Let's verify the version's availability and stability across all architectures.

✅ Verification successful

Version 1.78.1 is verified and available across all architectures

The verification confirms:

  • Version 1.78.1 packages are available for all required architectures (arm, arm64, 386, amd64)
  • The version is officially released and tagged on GitHub
  • All package URLs return HTTP 200 status, confirming their availability
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify Tailscale version 1.78.1 availability and release information

# Check if the version exists for all architectures
for arch in arm arm64 386 amd64; do
  echo "Checking $arch architecture..."
  curl -s -I "https://pkgs.tailscale.com/stable/tailscale_1.78.1_${arch}.tgz" | head -n 1
done

# Fetch release information from GitHub
gh api repos/tailscale/tailscale/releases/tags/v1.78.1 --jq '.body'

Length of output: 993


Line range hint 19-29: Verify package configuration compatibility with version 1.78.1

The installation commands and init script setup remain unchanged. Let's verify there are no new requirements or changes in the package structure for version 1.78.1.

✅ Verification successful

Let me gather more information about the package structure and installation requirements.


Let me check the official Tailscale release notes to verify if there are any installation changes or new requirements in version 1.78.1.


Package configuration is compatible with version 1.78.1

The package configuration remains valid for version 1.78.1:

  • The binary installation paths (/usr/bin/tailscale and /usr/sbin/tailscaled) are correct
  • The init script handles all required runtime configurations
  • No new files or configuration changes are required for this version
  • Architecture-specific package sources are properly defined
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for any changes in package structure or requirements

# Search for any version-specific changes in the repository
rg -A 5 "1.78.1" buildroot-external/package/tailscale/

# Check for any changes in installation requirements or new files
if [ -f "buildroot-external/package/tailscale/changelog.md" ]; then
  cat buildroot-external/package/tailscale/changelog.md
fi

Length of output: 1309


Script:

#!/bin/bash
# Check the contents of the package directory for any additional files or configurations
ls -la buildroot-external/package/tailscale/

# Check the init script to verify its compatibility
cat buildroot-external/package/tailscale/S46tailscaled

# Check if there are any patches or additional configuration files
fd . buildroot-external/package/tailscale/ -e patch -e config

Length of output: 2532


Script:

#!/bin/bash
# Check Config.in for any package dependencies or configurations
cat buildroot-external/package/tailscale/Config.in

# Check the package definition for any special handling
cat buildroot-external/package/tailscale/tailscale.mk

Length of output: 1388


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jens-maus jens-maus added the 💡 enhancement-ideas New feature or change request label Dec 24, 2024
@jens-maus jens-maus added this to the next release milestone Dec 24, 2024
@jens-maus jens-maus merged commit 1863e8b into jens-maus:master Dec 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 enhancement-ideas New feature or change request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants