Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for mobile devices #140

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support for mobile devices #140

wants to merge 2 commits into from

Conversation

Surfoo
Copy link

@Surfoo Surfoo commented Feb 28, 2015

No description provided.

@joequery
Copy link
Owner

Thanks for the pull request. Did the tests pass with your adjustments? And what mobile device was the plugin failing on before?

@Surfoo
Copy link
Author

Surfoo commented Feb 28, 2015

Oh sorry, I didn't execute the tests...

I have a Nexus 5 with Lollipop and I just tried with Chrome.
Maybe you will need to test with more devices, I don't know and I have only this smartphone.

@joequery
Copy link
Owner

joequery commented May 4, 2015

Hey there,

So I'm finally getting around to merging this in, and the code is actually incorrect.

$(this) within the callback function provided to all refers to the th we want sorted. If you take $(this) out of the callback context, it refers to the entire table instead of the th.

I will incorporate your first commit though :)

@joequery
Copy link
Owner

joequery commented May 4, 2015

It seems that touchend and click are not mutually exclusive events. Consequently, devices that support both will have a 'doubleclick' effect. Not quite sure what to do about this, there doesn't seem to be a 100% accurate solution based upon my research.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants