Repository navigation
Conversation
imharjot
force-pushed
the
fix/types-dist-path
branch
from
October 4, 2026 13:50
e432c12 to
83f6934
Compare
Author
|
Rebased onto current master and added a test against the installed tarball rather than only the source tree. It catches the missing advertised declaration on the original manifest, then compiles and runs both ESM and CommonJS consumers with the fix. All 50 tests pass locally. The new test passes ESLint; the repository-wide lint command still reports errors in unchanged files. |
Author
|
The refreshed workflow run is marked |
Techcrazee2017
approved these changes
Oct 15, 2026
Techcrazee2017
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package publishes
dist/, but its declaration paths point to the unpublished rootindex.d.ts. Point the top-leveltypesfield todist/index.d.tsand select the matching emitted declarations for ESM (index.d.mts) and CommonJS (index.d.ts).Added a test that builds and installs the actual tarball, checks that its advertised declaration files exist, then compiles and runs ESM and CommonJS consumers. The original manifest fails the missing-file check.
Validation:
npm testpassed (50 tests); the new test passes targeted ESLint. Repository-wide ESLint still reports existing errors in the unchanged source and configuration.Closes #37