Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All: add CSP report only header for all blog sites #8

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

timmywil
Copy link
Member

@timmywil timmywil commented Dec 24, 2024

  • allow scripts, styles, and images from code.jquery.com

I abandoned setting them via nginx since we don't know why they weren't getting set. I've set a minimal, report-only header for the blogs and will evaluate if any exceptions are needed after deployment.

An advantage of this strategy is no changes to the infra repo will be needed when the blogs are eventually switched over to use jquery-wp-content.

Ref jquery/infrastructure-puppet#54

- allow scripts, styles, and images from code.jquery.com
@timmywil timmywil requested a review from Krinkle December 24, 2024 19:30
@Krinkle
Copy link
Member

Krinkle commented Dec 25, 2024

FYI: blog theme in puppet uses default of ensure present, not latest. It also has no notify webhook yet. You can use ssh to wpblogs and git pull the directory in question. I usually keep note of git log -1 beforehand, so that I can easily git checkout $prevCommitHash to rollback in case of trouble.

@timmywil timmywil merged commit 80715f1 into jquery:main Dec 25, 2024
1 check passed
@timmywil timmywil deleted the csp branch December 25, 2024 16:15
@timmywil
Copy link
Member Author

I also had to run the puppet agent to get it to update, but the headers are showing up now. And I already see some exceptions that are needed (e.g. typekit scripts)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants