-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for arm64 targets #17
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need this as well!
Ping |
Well, I've accidentally pushed the same changes (closed already). So basically it works fair enough, here's my log: / # uname -a
Linux key-test 5.10.186-179.751.amzn2.aarch64 #1 SMP Tue Aug 1 20:51:46 UTC 2023 aarch64 Linux
/ # keyctl show
Session Keyring
954719602 --alswrv 0 0 keyring: _ses.4b0d344fee412fdbc258b6615332aa864b94d6d3f86ac39bd42bb44f44e84320
276939416 --alswrv 0 0 \_ user: test
/ # ./app
test
/ # keyctl print 276939416
test |
@jsipprell looks like several sites are using forks with this patch. Could you please merge this? |
@rzimmerman @tarvitz @arrestle Given that I assume each of us have a fork of this project with this patch, I wonder if we need to consider forking to a new community repo. |
@hallyn I don't have a proper answer for it. We required to have arm64 support, but I don't see any potential for any other architectures on our side. So @rzimmerman and mine changes (I made them accidentally because I missed this pr, but since they are trivial they look the same :) just support the current lib with a minor enhancement. Since the mine fork is used in a client-side app which is updated from time to time, I assume I'll continue to support it (in the case if the original/this repository remains silent) from the following perspectives:
|
Add syscall IDs for arm64.