Repository navigation
fix: Allow judoscale.rq without settings.JUDOSCALE - #143
Merged
Merged
Conversation
JudoscaleRQConfig.ready() already used getattr for config updates but still accessed settings.JUDOSCALE directly when connecting to Redis, so Django startup crashed when following the README REDIS_URL path.
adamlogic
pushed a commit
that referenced
this pull request
Oct 16, 2026
🤖 I have created a release *beep* *boop* --- ## [1.13.5](v1.13.4...v1.13.5) (2026-10-15) ### Bug Fixes * Allow judoscale.rq without settings.JUDOSCALE ([#143](#143)) ([bfa2be4](bfa2be4)) * Skip reporter in ephemeral containers ([#139](#139)) ([fb33242](fb33242)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #142. Adding
judoscale.rqwithout definingsettings.JUDOSCALEcrashed Django startup, even though the README says Redis falls back toREDIS_URL.JudoscaleRQConfig.ready()usedgetattr(settings, "JUDOSCALE", {})when updating config, then accessedsettings.JUDOSCALEdirectly when building the Redis connection — so the fallback only worked if the setting already existed.Design decisions
Reuse one
getattrresult for both the config update and the Redis lookup, instead of callinggetattrtwice. Behavior with an explicitJUDOSCALE/REDISconfig is unchanged.