Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agents-api): Increase api_call tools' timeouts to 60s #656

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

HamadaSalhab
Copy link
Contributor

@HamadaSalhab HamadaSalhab commented Oct 15, 2024

Important

Increase timeout to 60 seconds for HTTP requests in execute_api_call() in excecute_api_call.py.

  • Behavior:
    • Increase timeout to 60 seconds in execute_api_call() in excecute_api_call.py for HTTP requests using httpx.AsyncClient.

This description was created by Ellipsis for 7ff06bd. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 7ff06bd in 11 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. agents-api/agents_api/activities/excecute_api_call.py:34
  • Draft comment:
    Consider making the timeout value configurable instead of hardcoding it to 60 seconds. This would provide more flexibility for different environments or use cases.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR changes the timeout for the HTTP client, which is a straightforward change. However, it's important to ensure that the timeout is applied correctly and doesn't affect other parts of the code negatively.

Workflow ID: wflow_MDuLyYnu9OLvxqMK


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@creatorrr creatorrr merged commit 2689c0a into dev Oct 15, 2024
10 of 14 checks passed
@creatorrr creatorrr deleted the f/api-call-tool-timeout branch October 15, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants