Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug fixs for github action generate changelog #951

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

Vedantsahai18
Copy link
Member

@Vedantsahai18 Vedantsahai18 commented Dec 12, 2024

Important

Fixes GitHub Action workflow for changelog generation by correcting PR data handling and improving configuration.

  • Workflow Configuration:
    • Renames workflow from Julep-Changelog-Generation to Julep Changelog Generation in generate-changelog.yml.
    • Adds run-name to display the actor generating the changelog.
    • Removes unnecessary empty object from workflow_dispatch trigger.
  • Data Handling:
    • Changes how PR data is written to pr_data.json in generate-changelog.yml to avoid JSON structure.
    • Updates generate_changelog.py to read raw string data from pr_data.json instead of JSON object.

This description was created by Ellipsis for 4ba5a7e. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 4ba5a7e in 33 seconds

More details
  • Looked at 38 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_t160GCkHPz2bmabz


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

scripts/generate_changelog.py Show resolved Hide resolved
@Vedantsahai18 Vedantsahai18 merged commit 6b3aa25 into dev Dec 12, 2024
6 of 7 checks passed
@Vedantsahai18 Vedantsahai18 deleted the x/github-action branch December 12, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant