Repository navigation
Build outgoing messages without runtime dispatch - #129
Merged
Merged
Conversation
The send functions take params, result and the error fields as @nospecialize
values. Building a pair from such a value with => dispatches at runtime, so the
first message with a new value type compiled a Pair constructor at runtime, and
the Dict constructor and the JSON writer were called dynamically as well. The
julia-vscode REPL compiled Pair(String, Nothing) this way on every start
(8-16 ms), because the system image holds that method without native code and
a package image cannot add it.
The messages are now Dict{String,Any} built from explicit Pair{String,Any}
entries, which the compiler resolves statically. The JSON written to the wire
is unchanged apart from key order, which JSON does not define. A new test
checks the compiled send functions for runtime-dispatched calls that build or
serialize a message.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #129 +/- ##
==========================================
+ Coverage 88.31% 89.25% +0.94%
==========================================
Files 5 5
Lines 539 540 +1
==========================================
+ Hits 476 482 +6
+ Misses 63 58 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pfitzseb
approved these changes
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimizing startup time and this makes
julia-vscodea bit faster. It's not much, but the goal is a compilation-free startup.🤖:
The send functions take params, result and the error fields as @nospecialize values. Building a pair from such a value with => dispatches at runtime, so the first message with a new value type compiled a Pair constructor at runtime, and the Dict constructor and the JSON writer were called dynamically as well. The julia-vscode REPL compiled Pair(String, Nothing) this way on every start (8-16 ms), because the system image holds that method without native code and a package image cannot add it.
The messages are now Dict{String,Any} built from explicit Pair{String,Any} entries, which the compiler resolves statically. The JSON written to the wire is unchanged apart from key order, which JSON does not define. A new test checks the compiled send functions for runtime-dispatched calls that build or serialize a message.
For every PR, please check the following: