fix: emit an error when CIImage cannot be created #1273
Conversation
| @@ -7,12 +7,10 @@ import android.graphics.Matrix | |||
| import android.graphics.Rect | |||
| import android.hardware.display.DisplayManager | |||
| import android.net.Uri | |||
| import android.os.Build | |||
There was a problem hiding this comment.
Unused imports
| val inputImage: InputImage | ||
|
|
||
| try { | ||
| inputImage = InputImage.fromFilePath(activity, image) |
There was a problem hiding this comment.
Per the docs of InputImage.fromFilePath it throws an IOException if the path is not an image (with the error message "The image Uri could not be resolved.")
I believe not handling this here is why the method was not returning (we get an unhandled error, instead of calling the callbacks that would resolve the method call)
| @@ -7,7 +7,7 @@ version: 0.0.1 | |||
|
|
|||
| environment: | |||
| sdk: ">=3.3.0 <4.0.0" | |||
| flutter: ">=3.19.0" | |||
| flutter: ">=3.27.0" | |||
There was a problem hiding this comment.
Since Swift Package Manager support is now available on stable, I updated the constraint here
| @@ -16,6 +16,7 @@ | |||
| 97C147011CF9000F007C117D /* LaunchScreen.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = 97C146FF1CF9000F007C117D /* LaunchScreen.storyboard */; }; | |||
| A277671F4E603C31E191FCBF /* Pods_Runner.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = FB50C06655B1959BAA8EAF64 /* Pods_Runner.framework */; }; | |||
| F8C489EFA0FC3A131EBA1838 /* Pods_RunnerTests.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 9F20A7A668B7797BBB5443C1 /* Pods_RunnerTests.framework */; }; | |||
| 78A318202AECB46A00862997 /* FlutterGeneratedPluginSwiftPackage in Frameworks */ = {isa = PBXBuildFile; productRef = 78A3181F2AECB46A00862997 /* FlutterGeneratedPluginSwiftPackage */; }; | |||
There was a problem hiding this comment.
The changes in this file were generated by the Swift Package manager project migrator, during a flutter run.
| @@ -5,6 +5,24 @@ | |||
| <BuildAction | |||
| parallelizeBuildables = "YES" | |||
| buildImplicitDependencies = "YES"> | |||
| <PreActions> | |||
There was a problem hiding this comment.
This change was generated by the Swift Package manager project migrator, during a flutter run.
This PR adds the following changes:
Fixes #1244