fix: report analyze image as unsupported on iOS Simulator #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navaronbracke
commented
Jan 6, 2025
| @@ -22,5 +22,6 @@ class MobileScannerErrorCodes { | |||
| const val NO_CAMERA_ERROR_MESSAGE = "No cameras available." | |||
| const val SET_SCALE_WHEN_STOPPED_ERROR = "MOBILE_SCANNER_SET_SCALE_WHEN_STOPPED_ERROR" | |||
| const val SET_SCALE_WHEN_STOPPED_ERROR_MESSAGE = "The zoom scale cannot be changed when the camera is stopped." | |||
| const val UNSUPPORTED_OPERATION_ERROR = "MOBILE_SCANNER_UNSUPPORTED_OPERATION" // Reserved for future use. | |||
There was a problem hiding this comment.
Added here too, for feature parity with the iOS / macOS implementation, in case we need it in the future.
navaronbracke
commented
Jan 6, 2025
| @@ -48,17 +48,17 @@ public class MobileScannerPlugin: NSObject, FlutterPlugin, FlutterStreamHandler, | |||
| var standardZoomFactor: CGFloat = 1 | |||
|
|
|||
| public static func register(with registrar: FlutterPluginRegistrar) { | |||
| #if os(iOS) | |||
| #if os(iOS) | |||
There was a problem hiding this comment.
Formatted the compiler preprocessor directives to not have an indent, which is commonplace for these.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the iOS Simulator does not support the neural engine features that are required to run the Vision API,
hence why it fails to create the underlying detection model.
Fixes #1269