feat: Add optional gradle property for unbundled scanner #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woolfred
changed the title
navaronbracke
approved these changes
Oct 10, 2023
| implementation 'com.google.android.gms:play-services-mlkit-barcode-scanning:18.1.0' | ||
| } else { | ||
| // Bundled model in app | ||
| implementation 'com.google.mlkit:barcode-scanning:17.2.0' |
There was a problem hiding this comment.
@woolfred Is there a reason why the versions between the bundled and unbundled dependencies are different?
There was a problem hiding this comment.
I don't know why the version numbers differ 🤷 Simply wrapped the existing lines.
For the unbundled one the newest one is actually 18.3.0: https://mvnrepository.com/artifact/com.google.android.gms/play-services-mlkit-barcode-scanning
While 17.2.0 for the bundled one looks to be up to date: https://mvnrepository.com/artifact/com.google.mlkit/barcode-scanning
navaronbracke
approved these changes
Oct 10, 2023
|
I could not find a solution for this myself, so good to see it is possible! Thanks for your work, LGTM! |
joaopedro735
pushed a commit
to joaopedro735/mobile_scanner
that referenced
this pull request
Aug 22, 2024
…canner-dependency feat: Add optional gradle property for unbundled scanner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋
This is the PR based on #635 (comment)
This should also close this issue: #235
I added the possible configuration to the readme and made the part about bundled vs unbundled a bit more concise.
Let me know if you need anything else.
Cheers