Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scan window fix (cherry-pick) #778

Merged

Conversation

navaronbracke
Copy link
Collaborator

This is a cherry-pick of @MBulli his changes in #721 with the following additions:

  • documentation adjustments for the scan window function
  • using named parameters for the two Size arguments
  • formatting adjustments by adding missing comma's in the test

Test still passes locally.

Fixes #633

@navaronbracke navaronbracke changed the title Cherry pick scan window fix Fix: scan window fix (cherry-pick) Oct 12, 2023
@navaronbracke navaronbracke changed the title Fix: scan window fix (cherry-pick) fix: scan window fix (cherry-pick) Oct 12, 2023
@navaronbracke
Copy link
Collaborator Author

Thanks a lot @MBulli for the fixes!

@navaronbracke navaronbracke merged commit a7e3c14 into juliansteenbakker:master Oct 12, 2023
4 of 6 checks passed
@navaronbracke navaronbracke deleted the cherry_pick_scan_window_fix branch October 12, 2023 17:47
joaopedro735 pushed a commit to joaopedro735/mobile_scanner that referenced this pull request Aug 22, 2024
…ck_scan_window_fix

fix: scan window fix (cherry-pick)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scanWindow not applied correctly
3 participants