feat: RunnerTests for iOS/MacOS #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navaronbracke
commented
Oct 22, 2023
| end | ||
|
|
||
| post_install do |installer| | ||
| installer.pods_project.targets.each do |target| | ||
| flutter_additional_ios_build_settings(target) | ||
| target.build_configurations.each do |config| | ||
| config.build_settings['ENABLE_BITCODE'] = 'NO' |
There was a problem hiding this comment.
Bitcode hasn't been supported anymore for a while now.
navaronbracke
commented
Oct 22, 2023
| @@ -8,14 +8,26 @@ | |||
|
|
|||
| /* Begin PBXBuildFile section */ | |||
| 1498D2341E8E89220040F4C2 /* GeneratedPluginRegistrant.m in Sources */ = {isa = PBXBuildFile; fileRef = 1498D2331E8E89220040F4C2 /* GeneratedPluginRegistrant.m */; }; | |||
| 331C808B294A63AB00263BE5 /* RunnerTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 331C807B294A618700263BE5 /* RunnerTests.swift */; }; | |||
There was a problem hiding this comment.
Most of these changes are reorganising for the addition of the RunnerTests. This was done by the flutter create template.
navaronbracke
commented
Oct 22, 2023
| @@ -21,15 +21,24 @@ | |||
| /* End PBXAggregateTarget section */ | |||
|
|
|||
| /* Begin PBXBuildFile section */ | |||
| 331C80D8294CF71000263BE5 /* RunnerTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 331C80D7294CF71000263BE5 /* RunnerTests.swift */; }; | |||
There was a problem hiding this comment.
Ditto, but for MacOS.
navaronbracke
changed the title
joaopedro735
pushed a commit
to joaopedro735/mobile_scanner
that referenced
this pull request
Aug 22, 2024
…pp_ios_macos_cleanup feat: RunnerTests for iOS/MacOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a RunnerTests setup to the iOS/MacOS example app.
It adds the RunnerTests stub that is added by the template. (with the original function commented out, since it will be replaced in the end)
With the large changes to the iOS/MacOS workspace files, I've tested iOS/MacOS and they still run correctly.
The new RunnerTests also show up in the project navigator for iOS/MacOS, so that works as well.