fix: with the "noDuplicates", the same code is no longer detected after stopping and restarting the scanner #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ger detected after stopping and restarting the scanner. Fix: spamming code detection with "noDuplicates" detection speed on iOS.
pgeof
changed the title
pgeof
changed the title
navaronbracke
approved these changes
Oct 31, 2023
|
Just tested this with the repro steps from the issue and MacOS works fine with |
I must admit I did not think about macOS and the Vision API, but thank you for validating that! |
joaopedro735
pushed a commit
to joaopedro735/mobile_scanner
that referenced
this pull request
Aug 22, 2024
fix: with the "noDuplicates", the same code is no longer detected after stopping and restarting the scanner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a fix for the issue reported here #750, which I also encountered.
To summarize, we reset the variable that holds the list of recently scanned codes every time the mobile scanner controller is restarted. I also sorted the list to avoid false comparisons of lists with the same codes but in a different order.
Additionally, on iOS, I had a code that was being spammed even though the "noDuplicates" speed was enabled. Upon reviewing the code, I noticed that this occurred when an empty code list was returned by the scanner, which happens as soon as there are no more codes in the camera's field of view. So I added a check to ignore empty lists. In fact, this check was already present in the Android code.